Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade ingress addon files according to upstream(ingress-nginx v0.44.0) #10879

Merged
merged 1 commit into from
Mar 23, 2021
Merged

Upgrade ingress addon files according to upstream(ingress-nginx v0.44.0) #10879

merged 1 commit into from
Mar 23, 2021
+223 −170

Conversation

govargo
Copy link
Contributor

@govargo govargo commented Mar 19, 2021

What type of PR is this?

/area addons
/kind cleanup

What this PR does / why we need it:

This PR upgrades ingress addon according to upstream(kubernets/ingress-nginx).
Our minikube's ingress manifest files are very old, because they have been held since 2016, f1fb26a.
Our ingress addon's manifests are very different from upstream ones.
So, there are many differnces in this PR...

This PR upgrade ingress addon's version and K8s apiVersions.

Which issue(s) this PR fixes:

Fix #10855

Does this PR introduce a user-facing change?

Yes, this PR change ingress addon's version(to v0.44.0) and K8s apiVersions.

Before this PR

Namespace: kube-system
ValidatingWebhookConfiguration: admissionregistration.k8s.io/v1beta1
RoleBinding: rbac.authorization.k8s.io/v1beta1
nginx controller: k8s-artifacts-prod/ingress-nginx/controller:v0.40.2
Ingress: extensions/v1beta1

After this PR

Namespace: ingress-nginx
ValidatingWebhookConfiguration: admissionregistration.k8s.io/v1
RoleBinding: rbac.authorization.k8s.io/v1
nginx controller: ingress-nginx/controller:v0.44.0
Ingress: networking.k8s.io/v1beta1

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

@k8s-ci-robot k8s-ci-robot added area/addons kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 19, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @govargo. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 19, 2021
@govargo
Copy link
Contributor Author

govargo commented Mar 19, 2021

/assign @afbjorklund

@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@medyagh
Copy link
Member

medyagh commented Mar 21, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 21, 2021
@minikube-pr-bot
Copy link

kvm2 Driver
error collecting results for kvm2 driver: timing run 0 with Minikube (PR 10879): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/10879/minikube start --driver=kvm2]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/10879/minikube: exec format error
docker Driver
error collecting results for docker driver: timing run 0 with Minikube (PR 10879): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/10879/minikube start --driver=docker]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/10879/minikube: exec format error

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: govargo, medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 23, 2021
@medyagh medyagh merged commit afe31b1 into kubernetes:master Mar 23, 2021
@medyagh
Copy link
Member

medyagh commented Mar 23, 2021

thank you for refreshing the ingress addon

This was referenced Mar 23, 2021
Closed
Closed
@govargo govargo mentioned this pull request Apr 5, 2021
Closed
This was referenced Apr 24, 2021
Closed
Closed
Closed
Closed
Closed
bringer1092 added a commit to bringer1092/website that referenced this pull request May 24, 2021
@bringer1092
minikube 1.19.0 is Ingress namespace chaged
eda5cb8 
Ingress namespace is minikube 1.19.0 chage the status kube-system to ingress-nginx.
Since the output result has also changed, I decided to display only one line.
   
minikube 1.19.0 Upgrade ingress addon files according to upstream.
https://github.com/kubernetes/minikube/blob/master/CHANGELOG.md#version-1190-beta0---2021-04-05
kubernetes/minikube#10879

Before
---
NAME                                        READY     STATUS    RESTARTS   AGE
default-http-backend-59868b7dd6-xb8tq       1/1       Running   0          1m
kube-addon-manager-minikube                 1/1       Running   0          3m
kube-dns-6dcb57bcc8-n4xd4                   3/3       Running   0          2m
kubernetes-dashboard-5498ccf677-b8p5h       1/1       Running   0          2m
nginx-ingress-controller-5984b97644-rnkrg   1/1       Running   0          1m
storage-provisioner                         1/1       Running   0          2m
---

After
---
NAME                                        READY   STATUS      RESTARTS   AGE
ingress-nginx-controller-75fbcbcc56-q7lg8   1/1     Running     0          4h41m
---
This was referenced May 24, 2021
Closed
Closed
bringer1092 added a commit to bringer1092/website that referenced this pull request May 28, 2021
@bringer1092
minikube 1.19.0 is namespace changed
9b07ede 
minikube 1.19.0 Upgrade ingress addon files according to upstream.

https://github.com/kubernetes/minikube/blob/master/CHANGELOG.md#version-1190-beta0---2021-04-05
kubernetes/minikube#10879
bringer1092 added a commit to bringer1092/website that referenced this pull request May 28, 2021
@bringer1092
minikube 1.19.0 is namespace changed
0f24ab7 
ngress namespace is minikube 1.19.0 chage the status kube-system to ingress-nginx.

Since the output result has also changed, I decided to display only one line.

minikube 1.19.0 Upgrade ingress addon files according to upstream.

https://github.com/kubernetes/minikube/blob/master/CHANGELOG.md#version-1190-beta0---2021-04-05
kubernetes/minikube#10879
bringer1092 added a commit to bringer1092/website that referenced this pull request May 28, 2021
@bringer1092
Update ingress-minikube.md
98ec2c7 
ngress namespace is minikube 1.19.0 chage the status kube-system to ingress-nginx.

Since the output result has also changed, I decided to display only one line.

minikube 1.19.0 Upgrade ingress addon files according to upstream.

https://github.com/kubernetes/minikube/blob/master/CHANGELOG.md#version-1190-beta0---2021-04-05
kubernetes/minikube#10879
bringer1092 added a commit to bringer1092/website that referenced this pull request May 28, 2021
@bringer1092
minikube 1.19.0 is namespace changed
e10c87d 
Ingress namespace is minikube 1.19.0 chage the status kube-system to ingress-nginx.

Since the output result has also changed, I decided to display only one line.

minikube 1.19.0 Upgrade ingress addon files according to upstream.

https://github.com/kubernetes/minikube/blob/master/CHANGELOG.md#version-1190-beta0---2021-04-05
kubernetes/minikube#10879
@bringer1092 bringer1092 mentioned this pull request May 28, 2021
Closed
@Shubham82 Shubham82 mentioned this pull request Jun 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medyagh medyagh medyagh approved these changes

@prasadkatti prasadkatti Awaiting requested review from prasadkatti

@sharifelgamal sharifelgamal Awaiting requested review from sharifelgamal

Assignees

@afbjorklund afbjorklund

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/addons cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enabling 'ingress' returned an error: running callbacks: ....
6 participants
@govargo @k8s-ci-robot @minikube-bot @medyagh @minikube-pr-bot @afbjorklund