-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show last start and audit logs on minikube logs
if minikube not running
#10839
Conversation
Can one of the admins verify this patch? |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: medyagh, spowelljr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
/retest-this-please |
kvm2 Driver |
/retest-this-please |
Closes #10729
The first thing the
minkube logs
command does is tries loading the running cluster, and if the cluster config does not exist (not running), exits within the load function with the message:But if a user is having a problem starting minikube and wants to create a GitHub issue, this prevents them from getting the logs they need to provide in the issue.
I moved the last start and audit logs output before the cluster load to ensure they're output regardless of the status of the cluster.
Running
minikube logs
on non-running cluster:Before:
Now: