-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto-pause handle internal kubernetes requests #10823
Conversation
Can one of the admins verify this patch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since we are creating an image for the webhook, what do u think about moving the auto-pause server into the same image ?
and then run the Auto-Pause server as a Docker or Crictl Container inside minikube VM (or container)
To do that, we need to create the image contains docker and run container in privileged mode. I could try that once this pr is done. |
/ok-to-test |
kvm2 Driver |
@@ -99,6 +99,9 @@ SHA512SUM=$(shell command -v sha512sum || echo "shasum -a 512") | |||
# to update minikubes default, update deploy/addons/gvisor | |||
GVISOR_TAG ?= latest | |||
|
|||
# auto-pause-hook tag to push changes to | |||
AUTOPAUSE_HOOK_TAG ?= 1.13 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets not use the Dot notation here, it should be a simple One letter version,
like V1
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: azhao155, medyagh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Start minikube with auto-pause
env-inject will be created under auto-pause namespace
Deploy etcd-operator
etcd-operator is running now
Check env of etcd-operator
It's already pointing to reverse proxy.
Deploy etcd-cluster
etcd-cluster is deployed