Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: break down usage for no profile found #10800

Merged
merged 1 commit into from
Mar 12, 2021

Conversation

medyagh
Copy link
Member

@medyagh medyagh commented Mar 12, 2021

for better end user metric gathering breaking down the exit code words

creating new Exit Code Word MK_USAGE_NO_PROFILE and better icon (rather than a scary one that looks like an internal error)

before

$ minikube profile list

❌  Exiting due to MK_USAGE: No minikube profile was found. You can create one using `minikube start`.

after

🤹  Exiting due to MK_USAGE_NO_PROFILE: No minikube profile was found. 
💡  Suggestion: 

    You can create one using 'minikube start'.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 12, 2021
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 12, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, sharifelgamal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [medyagh,sharifelgamal]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@medyagh medyagh changed the title break down usage for no profile found ui: break down usage for no profile found Mar 12, 2021
@medyagh medyagh merged commit b6c4101 into kubernetes:master Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. pr_verified size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants