add validations --image-repository inputs

[yxxhero]

add validateImageRepository func for validates --image-repository args
This PR fix two error:

1. when --image-repository endswith "/", k8s can't start, because static pod image contain "//"
2. when --image-repository startswieh "http" or "https", it will think of http or https as a domain name.

error msg:
E0309 13:57:24.340121 73314 cache.go:63] save image to file "http:/harbor.example.com/google_images/dashboard:v2.1.0" -> "/home/minikube/.minikube/cache/images/http_/harbor.corp.qunar.com/google_images/dashboard_v2.1.0" failed: nil image for http:/harbor.example.com/google_images/dashboard:v2.1.0: Get "https://http/v2/": dial tcp: lookup http on 192.168.101.58:53: server misbehaving

[k8s-ci-robot]

Welcome @yxxhero!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @yxxhero. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[minikube-bot]

Can one of the admins verify this patch?

[yxxhero]

/retest

[k8s-ci-robot]

@yxxhero: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[yxxhero]

/retest

[k8s-ci-robot]

@yxxhero: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[medyagh]

@yxxhero thank you very much for fixing this, just a couple review comments

[medyagh]

/ok-to-test

[minikube-pr-bot]

kvm2 Driver
error collecting results for kvm2 driver: timing run 0 with Minikube (PR 10760): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/10760/minikube start --driver=kvm2]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/10760/minikube: exec format error
docker Driver
error collecting results for docker driver: timing run 0 with Minikube (PR 10760): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/10760/minikube start --driver=docker]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/10760/minikube: exec format error

[yxxhero]

/retest

[yxxhero]

kvm2 Driver
error collecting results for kvm2 driver: timing run 0 with Minikube (PR 10760): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/10760/minikube start --driver=kvm2]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/10760/minikube: exec format error
docker Driver
error collecting results for docker driver: timing run 0 with Minikube (PR 10760): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/10760/minikube start --driver=docker]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/10760/minikube: exec format error

the errors above because of me? @medyagh Thanks very much.

[yxxhero]

/retest

[yxxhero]

I check Jenkins faild jobs, I think it not because me. Thanks very much! @medyagh

[ohbus]

/lgtm

[k8s-ci-robot]

@ohbus: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, ohbus, yxxhero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [medyagh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment