Fix the failure of minikube mount in case of KVM2

[govargo]

What type of PR is this?

/kind bug
/area mount
/kind failing-test

What this PR does / why we need it:

Since minikube v1.18.0-beta, minikube mount in case of KVM2 always fail.
This PR will fix this bug.
The detail is here #10696 (comment).

Which issue(s) this PR fixes:

Fix #10696

Does this PR introduce a user-facing change?

Yes. This PR fixes minikube mount in case of KVM2

Before this PR

$ minikube mount /tmp/mounttest215617451:/mount-9p
...
I0306 11:15:57.542156   13465 ssh_runner.go:149] Run: /bin/bash -c "sudo mount -t 9p -o dfltgid=$(grep ^docker: /etc/group | cut -d: -f3),dfltuid=$(id -u docker),msize=262144,port=45947,trans=tcp,version=9p2000.L 192.168.39.181 /mount-9p"
I0306 11:15:57.564055   13465 out.go:129] 

W0306 11:15:57.564223   13465 out.go:191] ❌  Exiting due to GUEST_MOUNT: mount with cmd /bin/bash -c "sudo mount -t 9p -o dfltgid=$(grep ^docker: /etc/group | cut -d: -f3),dfltuid=$(id -u docker),msize=262144,port=45947,trans=tcp,version=9p2000.L 192.168.39.181 /mount-9p" : /bin/bash -c "sudo mount -t 9p -o dfltgid=$(grep ^docker: /etc/group | cut -d: -f3),dfltuid=$(id -u docker),msize=262144,port=45947,trans=tcp,version=9p2000.L 192.168.39.181 /mount-9p": Process exited with status 32
stdout:

stderr:
mount: /mount-9p: mount(2) system call failed: Connection refused.

❌  Exiting due to GUEST_MOUNT: mount with cmd /bin/bash -c "sudo mount -t 9p -o dfltgid=$(grep ^docker: /etc/group | cut -d: -f3),dfltuid=$(id -u docker),msize=262144,port=45947,trans=tcp,version=9p2000.L 192.168.39.181 /mount-9p" : /bin/bash -c "sudo mount -t 9p -o dfltgid=$(grep ^docker: /etc/group | cut -d: -f3),dfltuid=$(id -u docker),msize=262144,port=45947,trans=tcp,version=9p2000.L 192.168.39.181 /mount-9p": Process exited with status 32
stdout:

stderr:
mount: /mount-9p: mount(2) system call failed: Connection refused.

After this PR

$ minikube mount /tmp/mounttest215617451:/mount-9p
...
I0306 10:57:52.161387   13297 mount.go:72] mount successful: ""
I0306 10:57:52.164488   13297 out.go:129] ✅  Successfully mounted /tmp/mounttest215617451 to /mount-9p
✅  Successfully mounted /tmp/mounttest215617451 to /mount-9p
I0306 10:57:52.166544   13297 out.go:129] 

I0306 10:57:52.168562   13297 out.go:129] 📌  NOTE: This process must stay alive for the mount to be accessible ...
📌  NOTE: This process must stay alive for the mount to be accessible ...

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

[k8s-ci-robot]

Hi @govargo. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[govargo]

/assign @medyagh

[govargo]

Hi medya,
Could you comment /ok-to-test?
I'd like to check if TestFunctional/parallel/MountCmd of KVM test works.

Thank you,

[minikube-bot]

Can one of the admins verify this patch?

[medyagh]

/ok-to-test

[medyagh]

are u sure this is doing the right thing ? what if the KVM user has multiple minikube profiles, will they have same IP ?

[afbjorklund]

It was hardcoded before, but we missed to add the .1 at the end when making it more generic: d48b0a5

[govargo]

Fixed this. I wrote as the same as the vmware case.

[minikube-pr-bot]

kvm2 Driver
error collecting results for kvm2 driver: timing run 0 with Minikube (PR 10733): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/10733/minikube start --driver=kvm2]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/10733/minikube: exec format error
docker Driver
error collecting results for docker driver: timing run 0 with Minikube (PR 10733): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/10733/minikube start --driver=docker]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/10733/minikube: exec format error

[afbjorklund]

Leave the "GetIP", but change the last digit. That should work on most networks.

Like the VMware driver: return net.IPv4(vmIP[0], vmIP[1], vmIP[2], byte(1)), nil

[govargo]

Thank you very much @afbjorklund !!

I changed the code as you pointed out.

[govargo]

I can check the multiple minikube profiles case.

$ ./out/minikube start -p profile1
$ ./out/minikube start -p profile2

$ ./out/minikube mount /tmp/mounttest215617451:/mount-9p -p profile1
📁  Mounting host path /tmp/mounttest215617451 into VM as /mount-9p ...
    ▪ Mount type:   
    ▪ User ID:      docker
    ▪ Group ID:     docker
    ▪ Version:      9p2000.L
    ▪ Message Size: 262144
    ▪ Permissions:  755 (-rwxr-xr-x)
    ▪ Options:      map[]
    ▪ Bind Address: 192.168.39.1:44523
🚀  Userspace file server: ufs starting
✅  Successfully mounted /tmp/mounttest215617451 to /mount-9p

📌  NOTE: This process must stay alive for the mount to be accessible ...

$ ./out/minikube mount /tmp/mounttest215617451:/mount-9p -p profile2
📁  Mounting host path /tmp/mounttest215617451 into VM as /mount-9p ...
    ▪ Mount type:   
    ▪ User ID:      docker
    ▪ Group ID:     docker
    ▪ Version:      9p2000.L
    ▪ Message Size: 262144
    ▪ Permissions:  755 (-rwxr-xr-x)
    ▪ Options:      map[]
    ▪ Bind Address: 192.168.39.1:42719
🚀  Userspace file server: ufs starting
✅  Successfully mounted /tmp/mounttest215617451 to /mount-9p

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: govargo, sharifelgamal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sharifelgamal]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment