Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update go-container registry to 0.4.1 + patch #10731

Merged
merged 3 commits into from
Mar 10, 2021
Merged

Update go-container registry to 0.4.1 + patch #10731

merged 3 commits into from
Mar 10, 2021

Conversation

afbjorklund
Copy link
Collaborator

@afbjorklund afbjorklund commented Mar 6, 2021 •
edited
Loading

Rebase from v0.3.0 to v0.4.1

But go mod still says "v0.1.2" 🤷‍♂️

Closes #10677

@afbjorklund afbjorklund requested a review from medyagh March 6, 2021 08:14
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 6, 2021
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 6, 2021
@medyagh
Copy link
Member

medyagh commented Mar 6, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Mar 6, 2021
@minikube-pr-bot
Copy link

kvm2 Driver
error collecting results for kvm2 driver: timing run 0 with Minikube (PR 10731): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/10731/minikube start --driver=kvm2]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/10731/minikube: exec format error
docker Driver
error collecting results for docker driver: timing run 0 with Minikube (PR 10731): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/10731/minikube start --driver=docker]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/10731/minikube: exec format error

medyagh
medyagh requested changes Mar 10, 2021
View reviewed changes
Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build fails need rebase

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 10, 2021
@medyagh medyagh force-pushed the go_containerregistry-update2 branch from 0e73f30 to 40d50d7 Compare March 10, 2021 01:38
@medyagh medyagh self-requested a review March 10, 2021 01:39
@minikube-pr-bot
Copy link

kvm2 Driver
error collecting results for kvm2 driver: timing run 0 with Minikube (PR 10731): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/10731/minikube start --driver=kvm2]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/10731/minikube: exec format error
docker Driver
error collecting results for docker driver: timing run 0 with Minikube (PR 10731): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/10731/minikube start --driver=docker]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/10731/minikube: exec format error

@medyagh medyagh force-pushed the go_containerregistry-update2 branch from 40d50d7 to 938f552 Compare March 10, 2021 03:47
@medyagh medyagh merged commit 81eeb7d into kubernetes:master Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blueelvis blueelvis Awaiting requested review from blueelvis

@tstromberg tstromberg Awaiting requested review from tstromberg

@medyagh medyagh Awaiting requested review from medyagh

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update go-container registry lib fork
4 participants
@afbjorklund @medyagh @minikube-pr-bot @k8s-ci-robot