Add last start logs to minikube logs output #10465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
the
size/M
|
Can one of the admins verify this patch? |
spowelljr
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
spowelljr
force-pushed
the
addLastStart
branch
from
66ecadc
to
2ed6855
Compare
|
/ok-to-test |
k8s-ci-robot
added
the
ok-to-test
medyagh
approved these changes
Feb 24, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: medyagh, spowelljr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements: #10336
Instead of saving the start logs to the tmp directory with an irregular file name, the start logs are now stored in
.minikube/logs/lastStart.txt. The contents of this file will be replaced the next time a start command is run.The
minikube logscommand how outputs aLast Startsection using the logs inlastStart.txt.