Disallow running windows binary (.exe) inside WSL #10354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
do-not-merge/invalid-commit-message
|
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
k8s-ci-robot
added
the
cncf-cla: no
|
Welcome @hetong07! |
|
Hi @hetong07. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
needs-ok-to-test
k8s-ci-robot
added
the
size/S
|
Can one of the admins verify this patch? |
|
/retitle Disallow and give advice when running windows binary inside WSL |
|
@hetong07: Re-titling can only be requested by trusted users, like repository collaborators. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
hetong07
changed the title
k8s-ci-robot
removed
the
do-not-merge/invalid-commit-message
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
medyagh
requested changes
Feb 4, 2021
hetong07
force-pushed
the
issue_10311
branch
2 times, most recently
from
98cbf21
to
6549b95
Compare
… binary and modify the error name to address comments in pull request.
|
@medyagh I feel like that we do not need to create a new family for error code since we are not expecting such error to happen frequently. So I choose to use the |
|
kvm2 Driver Times for Minikube (PR 10354): 68.6s 65.2s 66.0s Averages Time Per Log docker Driver Times for Minikube (PR 10354): 27.5s 24.8s 25.2s Averages Time Per Log |
|
I signed it |
k8s-ci-robot
added
cncf-cla: yes
hetong07
changed the title
medyagh
requested changes
Feb 6, 2021
hetong07
changed the title
… check as early as possible.
|
kvm2 Driver Times for Minikube (PR 10354): 68.7s 67.2s 64.9s Averages Time Per Log docker Driver Times for Minikube (PR 10354): 25.5s 25.9s 25.6s Averages Time Per Log |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hetong07, medyagh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
medyagh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10311
Throws out MK_WRONG_BINARY_WSL error if user tries to run windows binary (.exe) inside WSL and advises them either to run with '--force' or download correct binary.
Before PR
After PR