add annotation to kubeconfig to identify contexts/clusters created by minikube

[medyagh]

After this PR the following extension blocks to the context and cluster section of ~/.kube/config

apiVersion: v1
clusters:
- cluster:
    certificate-authority: /Users/medya/.minikube/ca.crt
    extensions:
    - extension:
        last-update: Thu, 14 Jan 2021 15:41:04 PST
        provider: minikube.sigs.k8s.io
        version: v1.16.0
      name: cluster_info
    server: https://127.0.0.1:55000
  name: minikube
contexts:
- context:
    cluster: minikube
    extensions:
    - extension:
        last-update: Thu, 14 Jan 2021 15:41:04 PST
        provider: minikube.sigs.k8s.io
        version: v1.16.0
      name: context_info
    namespace: default
    user: minikube
  name: minikube
current-context: minikube
kind: Config
preferences: {}
users:
- name: minikube
  user:
    client-certificate: /Users/medya/.minikube/profiles/minikube/client.crt
    client-key: /Users/medya/.minikube/profiles/minikube/client.key

closes #9970

[sharifelgamal]

do we want to use hyphens instead of underscores (created-by and last-update instead of created_ by and last_update) to follow the convention set by kubeconfig?

[briandealwis]

I get your dislike of using cluster-type since they're Kubernetes clusters. But my concern about created-by is that it can refer to a tool like terraform. I wonder if there's a different term that we could settle on like provider. Basically within Skaffold I want to determine which helper command Skaffold should use to introspect on the cluster to find out more about its setup.

[medyagh]

I get your dislike of using cluster-type since they're Kubernetes clusters. But my concern about created-by is that it can refer to a tool like terraform. I wonder if there's a different term that we could settle on like provider. Basically within Skaffold I want to determine which helper command Skaffold should use to introspect on the cluster to find out more about its setup.

I dont think it is a good idea to call it cluster-type when minikube creates the cluster, minikube clusters are not a "type" they are same clusters created by standard "kubedam" it would be misleading or confusing for normal users to see in their kubeconfig it call it "cluster_type"= minikube since minikube is gateway to most starting with kuberentes, I dont want to suggest the idea we have a special type of clusters.

There is though an opportunity to create a community-wide standard naming, there doesnt seem to be any other tool using the "Extension" part of kubeconfig.

[medyagh]

I get your dislike of using cluster-type since they're Kubernetes clusters. But my concern about created-by is that it can refer to a tool like terraform. I wonder if there's a different term that we could settle on like provider. Basically within Skaffold I want to determine which helper command Skaffold should use to introspect on the cluster to find out more about its setup.

"provider" sounds like a good suggestion

[medyagh]

I get your dislike of using cluster-type since they're Kubernetes clusters. But my concern about created-by is that it can refer to a tool like terraform. I wonder if there's a different term that we could settle on like provider. Basically within Skaffold I want to determine which helper command Skaffold should use to introspect on the cluster to find out more about its setup.

"provider" sounds like a good suggestion

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, priyawadhwa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [medyagh,priyawadhwa]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[medyagh]

ad of underscores (created-by and last-update instead of created_ by and last_update) to follow the convention set by kubeconfig?

good idea

[medyagh]

/ok-to-test