disable scheduled stop service on minikube start

[tharun208]

Signed-off-by: Tharun rajendrantharun@live.com

Fixes #9865

@priyawadhwa I am able to do the enable the service only when scheduled-stop is initiated. But I went through different docs and references to make systemd services to be in an idle state. Need your help on this part.

[k8s-ci-robot]

Hi @tharun208. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tharun208
To complete the pull request process, please assign priyawadhwa after the PR has been reviewed.
You can assign the PR to them by writing /assign @priyawadhwa in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[minikube-bot]

Can one of the admins verify this patch?

[priyawadhwa]

Hey @tharun208 thanks for adding this. So disabling the service default would need to happen in two places:

1. The kic base image for the docker driver
2. The ISO for our VM drivers

For point 1 I think it may be as removing the ln command which links the service:

minikube/deploy/kicbase/Dockerfile

Line 156 in f17951c

RUN ln -fs /usr/lib/systemd/system/minikube-scheduled-stop.service \

(make sure you don't delete the chmod command that is included in that RUN statement)

To ensure this works locally, I would run:

make kic-base-image # To build the new version of the image
minikube start --base-image <name of new image> # To start minikube with your local kic image
minikube ssh -- sudo systemctl status scheduled-stop # To make sure the service is actually disabled

For the ISO, removing the same line here should do the trick:

minikube/deploy/iso/minikube-iso/package/scheduled-stop/scheduled-stop.mk

Line 13 in f17951c

ln -fs /usr/lib/systemd/system/minikube-scheduled-stop.service \

[priyawadhwa]

Let's also wait for #10132 to merge before merging this

[priyawadhwa]

Hey @tharun208 are you still working on this?

[ilya-zuyev]

This affects only windows, right? The updated function is used only in windows builds.

[priyawadhwa]

Hey @tharun208 this PR has been quiet for a few weeks now, I'm going to close it for now. Feel free to reopen whenever you have a chance to take a look at it!

[jiefenghe]

Hey @tharun208 thanks for adding this. So disabling the service default would need to happen in two places:

1. The kic base image for the docker driver
2. The ISO for our VM drivers

For point 1 I think it may be as removing the ln command which links the service:

minikube/deploy/kicbase/Dockerfile

Line 156 in f17951c

RUN ln -fs /usr/lib/systemd/system/minikube-scheduled-stop.service \

(make sure you don't delete the chmod command that is included in that RUN statement)

To ensure this works locally, I would run:

make kic-base-image # To build the new version of the image
minikube start --base-image <name of new image> # To start minikube with your local kic image
minikube ssh -- sudo systemctl status scheduled-stop # To make sure the service is actually disabled

For the ISO, removing the same line here should do the trick:

minikube/deploy/iso/minikube-iso/package/scheduled-stop/scheduled-stop.mk

Line 13 in f17951c

ln -fs /usr/lib/systemd/system/minikube-scheduled-stop.service \

Hi @priyawadhwa, I'm trying to continue tharun208's work. I have a few questions in terms of your comments:

1. make kic-base-image doesn't work. It will say make: *** No rule to make target 'kic-base-image'. Stop.
2. Why removing ln -fs /usr/lib/systemd/system/minikube-scheduled-stop.service /etc/systemd/system/multi-user.target.wants/minikube-scheduled-stop.service will stop the service by default? Because any files under /etc/systemd/sytem/multi-user.target.wants will be booted automatically? Otherwise, I was thinking maybe I can add systemctl disable minikube-scheduled-stop.service in the file to disable it.
3. Kic base image vs. ISO are two standards of image format?

[jiefenghe]

Hey @tharun208 thanks for adding this. So disabling the service default would need to happen in two places:

1. The kic base image for the docker driver
2. The ISO for our VM drivers

For point 1 I think it may be as removing the ln command which links the service:

minikube/deploy/kicbase/Dockerfile

Line 156 in f17951c

RUN ln -fs /usr/lib/systemd/system/minikube-scheduled-stop.service \

(make sure you don't delete the chmod command that is included in that RUN statement)
To ensure this works locally, I would run:

make kic-base-image # To build the new version of the image
minikube start --base-image <name of new image> # To start minikube with your local kic image
minikube ssh -- sudo systemctl status scheduled-stop # To make sure the service is actually disabled

For the ISO, removing the same line here should do the trick:

minikube/deploy/iso/minikube-iso/package/scheduled-stop/scheduled-stop.mk

Line 13 in f17951c

ln -fs /usr/lib/systemd/system/minikube-scheduled-stop.service \

Hi @priyawadhwa, I'm trying to continue tharun208's work. I have a few questions in terms of your comments:

1. make kic-base-image doesn't work. It will say make: *** No rule to make target 'kic-base-image'. Stop.
2. Why removing ln -fs /usr/lib/systemd/system/minikube-scheduled-stop.service /etc/systemd/system/multi-user.target.wants/minikube-scheduled-stop.service will stop the service by default? Because any files under /etc/systemd/sytem/multi-user.target.wants will be booted automatically? Otherwise, I was thinking maybe I can add systemctl disable minikube-scheduled-stop.service in the file to disable it.
3. Kic base image vs. ISO are two standards of image format?

I did more investigation and learnt that:

1. the kic-base-image rule has been deleted from the Makefile. I'll try to add another rule as discussed in https://kubernetes.slack.com/archives/C1F5CT6Q1/p1613893823024200
2. I ran systemctl disable minikube-scheduled-stop.service and noticed that it will remove the /etc/systemd/system/multi-user.target.wants/minikube-scheduled-stop.service symblink. So your suggestion makes sense.