Fix docker inspect network go template for network which doesn't have MTU #10053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
Hi @azhao155. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
size/XS
|
fix #10033 |
|
Can one of the admins verify this patch? |
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
|
kvm2 Driver |
|
/retest-this-please |
medyagh
reviewed
Dec 29, 2020
|
we can also have a Specific Error Type to return if the user's docker has issue and user needs to upgrade docker so the idea is we add a check later, if user is using a problamatic docker version, we will return a speccific error type to the exit. so we can give them a good solution message. example of errror types |
k8s-ci-robot
added
size/M
|
kvm2 Driver Times for Minikube (PR 10053): 60.1s 59.1s 58.0s Averages Time Per Log docker Driver Times for Minikube (PR 10053): 23.5s 23.3s 23.5s Averages Time Per Log |
medyagh
reviewed
Dec 30, 2020
medyagh
requested changes
Dec 30, 2020
|
kvm2 Driver Times for Minikube (PR 10053): 58.0s 59.8s 57.9s Averages Time Per Log docker Driver Times for Minikube (PR 10053): 23.7s 23.1s 22.6s Averages Time Per Log |
|
kvm2 Driver Times for Minikube (PR 10053): 59.9s 58.9s 60.9s Averages Time Per Log docker Driver Times for Minikube (PR 10053): 24.0s 24.4s 24.9s Averages Time Per Log |
medyagh
approved these changes
Dec 31, 2020
k8s-ci-robot
added
the
approved
medyagh
approved these changes
Dec 31, 2020
|
thank you for fixing this and adding unit tests for it too |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: azhao155, medyagh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First create network without MTU
Create network with MTU
So this go template will work in both scenarios.