-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added sch_htb, cls_fw, cls_matchall, act_connmark and ifb kernel modules #10048
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @imilchev! |
Hi @imilchev. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Can one of the admins verify this patch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you for your contribution!
Have you been able to build the ISO yourself with these changes and make sure they work for your use case?
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: imilchev, priyawadhwa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Yes, I did build the ISO and tested it. Although it took me a while to figure out that I cannot build it on a Mac even though it builds within Docker. The changes indeed solve the HTB issue mentioned and I also added a bunch of other modules related to marking and filtering packets since they are often used in such tools. I intentionally built them as modules since probably not so many people are interested in those |
@imilchev thank you for this PR |
Added these modules since they allow for traffic shaping within minikube by the use of
tc
. It also allows for using certain chaos engineering tools since they rely on these modules for simulating latency by the use of HTB, for example. This also fixes #6721.