Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usability: check addon status before disable. #4417

Closed
fenglixa opened this issue Jun 3, 2019 · 1 comment · Fixed by #4424
Closed

Usability: check addon status before disable. #4417

fenglixa opened this issue Jun 3, 2019 · 1 comment · Fixed by #4424
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@fenglixa
Copy link
Contributor

fenglixa commented Jun 3, 2019

Usability issue. While disable an addon, should message to user the addon is not enabled, but not a disabled failed crash message as below:

The exact command to reproduce the issue:
minikube addons disable heapster

The full output of the command that failed:
✘ > ~/Documents/GitHub/minikube_fengli > > master > minikube addons disable heapster
✅ heapster was successfully disabled
~/Documents/GitHub/minikube_fengli > > master > minikube addons disable heapster

💣 disable failed: [disabling addon deploy/addons/heapster/influx-grafana-rc.yaml.tmpl: Process exited with status 1]
😿 Sorry that minikube crashed. If this was unexpected, we would love to hear from you:
👉 https://github.com/kubernetes/minikube/issues/new

The output of the minikube logs command:

✘ > ~/Documents/GitHub/minikube_fengli > > master > minikube logs |tail
2019/06/03 13:28:04 Metric client health check failed: the server is currently unable to handle the request (get services heapster). Retrying in 30 seconds.
2019/06/03 13:28:34 Metric client health check failed: the server is currently unable to handle the request (get services heapster). Retrying in 30 seconds.
2019/06/03 13:29:04 Metric client health check failed: the server is currently unable to handle the request (get services heapster). Retrying in 30 seconds.
2019/06/03 13:29:34 Metric client health check failed: the server is currently unable to handle the request (get services heapster). Retrying in 30 seconds.
2019/06/03 13:30:04 Metric client health check failed: the server is currently unable to handle the request (get services heapster). Retrying in 30 seconds.
2019/06/03 13:30:34 Metric client health check failed: the server is currently unable to handle the request (get services heapster). Retrying in 30 seconds.
2019/06/03 13:31:04 Metric client health check failed: the server is currently unable to handle the request (get services heapster). Retrying in 30 seconds.
2019/06/03 13:31:34 Metric client health check failed: the server is currently unable to handle the request (get services heapster). Retrying in 30 seconds.

==> storage-provisioner <==

The operating system version:
MAC OS

@sharifelgamal sharifelgamal added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Jun 3, 2019
@dpandhi-git
Copy link
Contributor

would like to work on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants