add TODO with issue link

kubernetes · Apr 30, 2020 · c3a9fea · c3a9fea
1 parent d640753
commit c3a9fea
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/pkg/minikube/node/cache.go b/pkg/minikube/node/cache.go
@@ -110,7 +110,8 @@ func beginDownloadKicArtifacts(g *errgroup.Group, driver string, cRuntime string
 				glog.Infof("Downloading %s to local daemon", baseImage)
 				err := image.WriteImageToDaemon(baseImage)
 				if err != nil {
-					// registry/driver package uses viper.Set
+					// TODO : remove this global set when this issue is closed
+					// https://github.com/kubernetes/minikube/issues/7944
 					viper.Set("base-image", kic.BaseImageFallBack)
 					glog.Infof("failed to download %s will try to download the fallback image from %s", baseImage, kic.BaseImageFallBack)
 					return image.WriteImageToDaemon(kic.BaseImageFallBack)