Skip to content

Commit

Permalink
Add response to get error, disable service check on macOS/Windows
Browse files Browse the repository at this point in the history
  • Loading branch information
tstromberg committed Apr 2, 2020
1 parent a71edc3 commit 5266b69
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion test/integration/functional_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -335,8 +335,9 @@ func validateDashboardCmd(ctx context.Context, t *testing.T, profile string) {

resp, err := retryablehttp.Get(u.String())
if err != nil {
t.Fatalf("failed to http get %q : %v", u.String(), err)
t.Fatalf("failed to http get %q: %v\nresponse: %+v", u.String(), err, resp)
}

if resp.StatusCode != http.StatusOK {
body, err := ioutil.ReadAll(resp.Body)
if err != nil {
Expand Down Expand Up @@ -617,6 +618,10 @@ func validateServiceCmd(ctx context.Context, t *testing.T, profile string) {
t.Errorf("expected 'service list' to contain *hello-node* but got -%q-", rr.Stdout.String())
}

if NeedsPortForward() {
t.Skipf("test is broken for port-forwarded drivers: https://github.com/kubernetes/minikube/issues/7383")
}

// Test --https --url mode
rr, err = Run(t, exec.CommandContext(ctx, Target(), "-p", profile, "service", "--namespace=default", "--https", "--url", "hello-node"))
if err != nil {
Expand Down

0 comments on commit 5266b69

Please sign in to comment.