Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote block volumes to GA #88673

Merged
merged 2 commits into from
Mar 3, 2020
Merged

Promote block volumes to GA #88673

merged 2 commits into from
Mar 3, 2020

Conversation

jsafrane
Copy link
Member

@jsafrane jsafrane commented Feb 28, 2020 •
edited
Loading

What type of PR is this?
/kind feature

What this PR does / why we need it:
Promote both BlockVolume and CSIBlockVolume to GA.

Does this PR introduce a user-facing change?:

BlockVolume and CSIBlockVolume features are now GA.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP] https://github.com/kubernetes/enhancements/blob/master/keps/sig-storage/20190130-csi-raw-block-support.md
- [KEP] https://github.com/kubernetes/enhancements/blob/master/keps/sig-storage/20191008-raw-block-support.md
- [Other doc]: https://github.com/kubernetes/website/pull/19338

Block volume progress is tracked in https://github.com/orgs/kubernetes-csi/projects/4. Only #88660 remains to be merged and I have high confidence it's going to catch dev freeze.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/kubelet kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 28, 2020
@jsafrane
Copy link
Member Author

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 28, 2020
@fejta-bot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@jsafrane
Copy link
Member Author

/label api-review
for beta -> GA field change

@k8s-ci-robot k8s-ci-robot added the api-review Categorizes an issue or PR as actively needing an API review. label Feb 28, 2020
@jsafrane
Copy link
Member Author

cc @saad-ali @msau42 @gnufied
for review

@msau42
Copy link
Member

msau42 commented Mar 2, 2020

/assign @msau42

@smarterclayton
Copy link
Contributor

A few questions, first pass looks good otherwise.

@jsafrane
Copy link
Member Author

jsafrane commented Mar 2, 2020

@smarterclayton, feedback addressed, PTAL

@jsafrane
Copy link
Member Author

jsafrane commented Mar 3, 2020

/retest

@smarterclayton
Copy link
Contributor

/approve

This is approved for API changes.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 3, 2020
@msau42
Copy link
Member

msau42 commented Mar 3, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 3, 2020
@k8s-ci-robot k8s-ci-robot merged commit 9d0cbb7 into kubernetes:master Mar 3, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Mar 3, 2020
@ialidzhikov ialidzhikov mentioned this pull request Jul 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smarterclayton smarterclayton smarterclayton approved these changes

Assignees

@msau42 msau42

Labels
api-review Categorizes an issue or PR as actively needing an API review. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.
5 participants
@jsafrane @fejta-bot @msau42 @smarterclayton @k8s-ci-robot