Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Service Control Manager as the Windows Initsystem #78189

Merged
merged 2 commits into from
Jun 1, 2019
Merged

Use Service Control Manager as the Windows Initsystem #78189

merged 2 commits into from
Jun 1, 2019

Conversation

ksubrmnn
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug

/kind cleanup

/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
This PR updates the initsystem implementation for Windows to use golang.org/x/sys/windows/svc/mgr. This package allows us to make calls to the Windows Service Control Manager
Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 21, 2019
@ksubrmnn
Copy link
Contributor Author

/assign @neolit123
/assign @rosti

@k8s-ci-robot k8s-ci-robot added area/kubeadm sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 21, 2019
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 21, 2019
@ksubrmnn
Copy link
Contributor Author

/test pull-kubernetes-kubemark-e2e-gce-big

rosti
rosti approved these changes May 22, 2019
View reviewed changes
Copy link
Contributor

@rosti rosti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
For kubeadm changes

@ksubrmnn
Copy link
Contributor Author

ksubrmnn commented May 22, 2019 •
edited
Loading

/assign @thockin

neolit123
neolit123 suggested changes May 25, 2019
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ksubrmnn , i've added a couple of comments and questions, but the file split and new service manager LGTM.
thanks

pkg/util/initsystem/initsystem_windows.go Outdated Show resolved Hide resolved
pkg/util/initsystem/initsystem_windows.go Outdated Show resolved Hide resolved
pkg/util/initsystem/initsystem_windows.go Show resolved Hide resolved
pkg/util/initsystem/initsystem_windows.go Outdated Show resolved Hide resolved
@neolit123
Copy link
Member

/unassign @thockin

@neolit123
Copy link
Member

/priority important-longterm

@k8s-ci-robot k8s-ci-robot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 27, 2019
dineshgovindasamy
dineshgovindasamy approved these changes May 30, 2019
View reviewed changes
Copy link

@dineshgovindasamy dineshgovindasamy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes quickly. Looks good.

/LGTM

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 30, 2019
@brendandburns
Copy link
Contributor

I took a quick scan, this looks good to me. I'm happy to approve if we think the right reviewers have gotten a look at it...

@dineshgovindasamy
Copy link

/retest

@neolit123
Copy link
Member

/lgtm
/approve

@brendanburns this is good to go.
thanks.

we should probably add a separate owners file here with sig-node / cluster-lifecycle.

@ksubrmnn
Copy link
Contributor Author

/milestone v1.15

@k8s-ci-robot
Copy link
Contributor

@ksubrmnn: You must be a member of the kubernetes/kubernetes-milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone v1.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@brendandburns
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, ksubrmnn, neolit123, rosti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 30, 2019
@neolit123 neolit123 mentioned this pull request May 30, 2019
Open
17 tasks
@PatrickLang PatrickLang mentioned this pull request May 30, 2019
Open
@PatrickLang
Copy link
Contributor

/milestone v1.15

@k8s-ci-robot k8s-ci-robot added this to the v1.15 milestone May 30, 2019
@ksubrmnn
Copy link
Contributor Author

@PatrickLang let's keep an eye on this so it gets merged

@k8s-ci-robot k8s-ci-robot merged commit 5d1409a into kubernetes:master Jun 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neolit123 neolit123 neolit123 requested changes

@rosti rosti rosti approved these changes

@dineshgovindasamy dineshgovindasamy dineshgovindasamy approved these changes

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

@thockin thockin Awaiting requested review from thockin

Assignees

@neolit123 neolit123

@rosti rosti

@dineshgovindasamy dineshgovindasamy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.15
Development

Successfully merging this pull request may close these issues.
8 participants
@ksubrmnn @neolit123 @brendandburns @dineshgovindasamy @k8s-ci-robot @PatrickLang @rosti @thockin