Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HugePages feature is beta in 1.10 release #56939

Merged
merged 1 commit into from
Jan 6, 2018
Merged

HugePages feature is beta in 1.10 release #56939

merged 1 commit into from
Jan 6, 2018

Conversation

derekwaynecarr
Copy link
Member

What this PR does / why we need it:
Graduate support of HugePages to beta.

Which issue(s) this PR fixes
Fixes #53672

Special notes for your reviewer:

HugePages feature is beta

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 7, 2017
@derekwaynecarr derekwaynecarr added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 7, 2017
@derekwaynecarr derekwaynecarr mentioned this pull request Dec 7, 2017
Merged
@derekwaynecarr derekwaynecarr mentioned this pull request Dec 7, 2017
Closed
6 tasks
@tianshapjq
Copy link
Contributor

tianshapjq commented Dec 8, 2017 •
edited
Loading

/cc
hugepages in 1.10 looks like a huge project.

@k8s-ci-robot
Copy link
Contributor

@tianshapjq: GitHub didn't allow me to request PR reviews from the following users: tianshapjq.

Note that only kubernetes members can review this PR, and authors cannot review their own PRs.

In response to this:

/cc
looks like a huge project.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@brendandburns
Copy link
Contributor

@derekwaynecarr what has changed between the 1.9 release and now to make this qualify for beta?

If we have additional work planned, it feels like we should wait until its done.

If we don't have additional work planned, why wait to 1.10?

@tianshapjq
Copy link
Contributor

@brendandburns HugePages work tracker, maybe this is the work plan for 1.10.

@brendandburns
Copy link
Contributor

Looked at the work tracker, let's merge this once the other two items in the beta list are merged...

@derekwaynecarr
Copy link
Member Author

@brendanburns -- i held this pending merge of #54379

@derekwaynecarr
Copy link
Member Author

@brendandburns -- prerequisite pr has merged, this should be good to go.

@derekwaynecarr derekwaynecarr removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 5, 2018
@derekwaynecarr derekwaynecarr added this to the v1.10 milestone Jan 5, 2018
@sjenning sjenning mentioned this pull request Jan 5, 2018
Closed
@spiffxp
Copy link
Member

spiffxp commented Jan 5, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 5, 2018
@spiffxp spiffxp added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 5, 2018
@k8s-github-robot
Copy link

/test all

Tests are more than 96 hours old. Re-running tests.

@dchen1107
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 5, 2018
@brendandburns
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, dchen1107, derekwaynecarr, spiffxp

Associated issue: #53672

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 57906, 57425, 56939, 57317, 57762). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit a75c73a into kubernetes:master Jan 6, 2018
@tengqm tengqm mentioned this pull request Feb 13, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@spiffxp spiffxp

@brendandburns brendandburns

@dchen1107 dchen1107

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.10
Development

Successfully merging this pull request may close these issues.

HugePages work tracker
7 participants
@derekwaynecarr @tianshapjq @k8s-ci-robot @brendandburns @spiffxp @k8s-github-robot @dchen1107