Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cadvisor godeps to v0.27.2 #54827

Merged
merged 1 commit into from
Oct 31, 2017
Merged

Update cadvisor godeps to v0.27.2 #54827

merged 1 commit into from
Oct 31, 2017

Conversation

dashpole
Copy link
Contributor

@dashpole dashpole commented Oct 31, 2017 •
edited
Loading

This fixes an issue with overlay2 support for Docker and CRI-O, which was introduced in 1.8.

We should cherrypick this to the 1.8 branch.

cc @kubernetes/sig-node-pr-reviews
@derekwaynecarr @dchen1107

Fix overlay2 container disk metrics for Docker and CRI-O

@k8s-ci-robot
Copy link
Contributor

@dashpole: Adding do-not-merge/release-note-label-needed because the release note process has not been followed.

One of the following labels is required "release-note", "release-note-action-required", or "release-note-none".
Please see: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#write-release-notes-if-needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 31, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dashpole
We suggest the following additional approver: brendandburns

Assign the PR to them by writing /assign @brendandburns in a comment when ready.

No associated issue. Update pull-request body to add a reference to an issue, or get approval with /approve no-issue

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 31, 2017
@dashpole
Copy link
Contributor Author

/assign @runcom @derekwaynecarr @dchen1107
/unassign @brendanburns @lavalamp

dchen1107
dchen1107 reviewed Oct 31, 2017
View reviewed changes
Godeps/Godeps.json
@@ -30,32 +30,32 @@
},
{
"ImportPath": "github.com/Azure/azure-sdk-for-go/arm/compute",
"Comment": "v10.0.4-beta-1-g786cc84",
"Comment": "v10.0.4-beta-1-g786cc841",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why those pkgs are changed from g786cc84 to g786cc841?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure. the revision is still the same, so it shouldn't matter.

@dchen1107 dchen1107 added this to the v1.8 milestone Oct 31, 2017
@dchen1107 dchen1107 added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cherrypick-candidate labels Oct 31, 2017
@dchen1107
Copy link
Member

cc/ @kubernetes/kubernetes-release-managers for v1.8 patch release.

@jpbetz jpbetz added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed cherrypick-candidate labels Oct 31, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 54774, 54820, 52192, 54827). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit ef9d217 into kubernetes:master Oct 31, 2017
@dashpole dashpole deleted the cadvisor_godep branch October 31, 2017 20:25
@dashpole dashpole mentioned this pull request Oct 31, 2017
Merged
k8s-github-robot pushed a commit that referenced this pull request Nov 1, 2017
Merge pull request #54882 from dashpole/automated-cherry-pick-of-#548…
630e2ea 
…27-upstream-release-1.8

Automatic merge from submit-queue.

Automated cherry pick of #54827

Cherry pick of #54827 on release-1.8.

#54827: update cadvisor godeps to v0.27.2

```release-note
Fix overlay2 container disk metrics for Docker and CRI-O
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dchen1107 dchen1107 dchen1107 left review comments

Assignees

@runcom runcom

@derekwaynecarr derekwaynecarr

@dchen1107 dchen1107

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.
9 participants
@dashpole @k8s-ci-robot @k8s-github-robot @dchen1107 @jpbetz @lavalamp @runcom @brendandburns @derekwaynecarr