kubeapiserver: rename `--experimental-bootstrap-token-auth` to `--enable-bootstrap-token-auth`. #51198

mattmoyer · 2017-08-23T15:00:39Z

#What this PR does / why we need it:
This change renames the API server --experimental-bootstrap-token-auth flag to --enable-bootstrap-token-auth. The old flag is accepted but generates a warning.

In 1.9, we will drop support for --experimental-bootstrap-token-auth entirely.

Example of the warning log:

$ kube-apiserver --experimental-bootstrap-token-auth --etcd-servers https://127.0.0.1:1234 --service-cluster-ip-range 10.0.1.0/24
Flag --experimental-bootstrap-token-auth has been deprecated, use --enable-bootstrap-token-auth instead.
[...]

Which issue this PR fixes fixes #50613

Release note:

Renamed the API server flag `--experimental-bootstrap-token-auth` to `--enable-bootstrap-token-auth`. The old value is accepted with a warning in 1.8 and will be removed in 1.9.

/sig cli
/sig cluster-lifecycle

cc @luxas

luxas

LGTM, thanks!

one naming nit to consider, but not blocking

luxas · 2017-08-23T15:05:58Z

pkg/kubeapiserver/options/authentication.go

@@ -51,7 +51,8 @@ type AnonymousAuthenticationOptions struct {
 }

 type BootstrapTokenAuthenticationOptions struct {
-	Allow bool
+	Allow             bool
+	AllowExperimental bool


nit: Enable and DeprecatedEnableExperimental or something?

Yeah, that sounds good. Will fix.

luxas · 2017-08-23T15:06:55Z

cc @kubernetes/sig-cluster-lifecycle-pr-reviews @kubernetes/sig-auth-pr-reviews

liggitt · 2017-08-23T15:37:30Z

pkg/kubeapiserver/options/authentication.go

@@ -51,7 +51,8 @@ type AnonymousAuthenticationOptions struct {
 }

 type BootstrapTokenAuthenticationOptions struct {
-	Allow bool
+	Enable                       bool
+	DeprecatedEnableExperimental bool


don't spread flag-specific things into the options structs... keep the single bool, bind two flags to it, and use fs.MarkDeprecated on the old flag

Thanks, I was looking for something like fs.MarkDeprecated but didn't find it. This is much better.

liggitt · 2017-08-23T15:38:07Z

cmd/kube-apiserver/app/options/validation.go

@@ -45,6 +45,15 @@ func validateServiceNodePort(options *ServerRunOptions) []error {
 	return errors
 }

+func validateBootstrapTokenAuthFlags(options *ServerRunOptions) []error {


this isn't needed... if you use the old flag, you'll get a deprecation warning. in two releases when we remove it, you'll get an error then.

…ble-bootstrap-token-auth`. This change renames the `--experimental-bootstrap-token-auth` flag to `--enable-bootstrap-token-auth`. The old flag is accepted but generates a warning. In 1.9, we will drop support for `--experimental-bootstrap-token-auth` entirely.

liggitt · 2017-08-23T16:27:30Z

/lgtm

k8s-github-robot · 2017-08-23T16:27:44Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, mattmoyer

Associated issue: 50613

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

~~pkg/kubeapiserver/OWNERS~~ [liggitt]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

mattmoyer · 2017-08-24T14:05:56Z

/retest

mattmoyer · 2017-08-24T14:30:21Z

I filed the unit test flake here: #51270

mattmoyer · 2017-08-24T14:57:40Z

Also flaking on #51253.

k8s-github-robot · 2017-08-24T18:17:07Z

Automatic merge from submit-queue (batch tested with PRs 50713, 47660, 51198, 51159, 51195)

This has some changes I missed when I was updating the main kubeadm documention: - Bootstrap tokens are now beta, not alpha (kubernetes/enhancements#130) - The apiserver flag to enable the authenticator changedin 1.8 (kubernetes/kubernetes#51198) - Added `auth-extra-groups` documentaion (kubernetes/kubernetes#50933) - Updated the _Token Management with `kubeadm`_ section to link to the main kubeadm docs, since it was just duplicated information.

This flag was replaced by `--enable-bootstrap-token-auth` in 1.8 (kubernetes#51198).

* Update bootstrap tokens doc for 1.8. This has some changes I missed when I was updating the main kubeadm documention: - Bootstrap tokens are now beta, not alpha (kubernetes/enhancements#130) - The apiserver flag to enable the authenticator changedin 1.8 (kubernetes/kubernetes#51198) - Added `auth-extra-groups` documentaion (kubernetes/kubernetes#50933) - Updated the _Token Management with `kubeadm`_ section to link to the main kubeadm docs, since it was just duplicated information. * Update bootstrap-tokens.md

…token-auth Automatic merge from submit-queue (batch tested with PRs 52355, 52537, 52551, 52403, 50673). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.. Drop --experimental-bootstrap-token-auth flag. **What this PR does / why we need it**: Drops support for the `--experimental-bootstrap-token-auth` flag for the API server. This flag was replaced by `--enable-bootstrap-token-auth` in 1.8 (#51198) but the old flag was accepted with a deprecation warning. In 1.9 we want to totally drop it. **Which issue this PR fixes**: fixes #50613 **Special notes for your reviewer**: There are other places in kubeadm where we need to drop support for this flag (at init and at postupgrade). We can tackle those in a separate PR. **Release note**: I think this change is already document well enough in the changelog for 1.8. ```release-note NONE ``` @kubernetes/sig-cluster-lifecycle-pr-reviews @kubernetes/sig-auth-pr-reviews /kind cleanup

@chenopis

* GC now supports non-core resources * Add two examples about how to analysis audits of kube-apiserver (#4264) * Deprecate system:nodes binding * [1.8] StatefulSet `initialized` annotation is now ignored. * inits the kubeadm upgrade docs addresses /issues/4689 * adds kubeadm upgrade cmd to ToC addresses /issues/4689 * add workload placement docs * ScaleIO - document udpate for 1.8 * Add documentation on storageClass.mountOptions and PV.mountOptions (#5254) * Add documentation on storageClass.mountOptions and PV.mountOptions * convert notes into callouts * Add docs for CustomResource validation add info about supported fields * advanced audit beta features (#5300) * Update job workload doc with backoff failure policy (#5319) Add to the Jobs documentation how to use the new backoffLimit field that limit the number of Pod failure before considering the Job as failed. * Documented additional AWS Service annotations (#4864) * Add device plugin doc under concepts/cluster-administration. (#5261) * Add device plugin doc under concepts/cluster-administration. * Update device-plugins.md * Update device-plugins.md Add meta description. Fix typo. Change bare metal deployment to manual deployment. * Update device-plugins.md Fix typo again. * Update page.version. (#5341) * Add documentation on storageClass.reclaimPolicy (#5171) * [Advanced audit] use new herf for audit-api (#5349) This tag contains all the changes in v1beta1 version. Update it now. * Added documentation around creating the InitializerConfiguration for the persistent volume label controller in the cloud-controller-manager (#5255) * Documentation for kubectl plugins (#5294) * Documentation for kubectl plugins * Update kubectl-plugins.md * Update kubectl-plugins.md * Updated CPU manager docs to match implementation. (#5332) * Noted limitation of alpha static cpumanager. * Updated CPU manager docs to match implementation. - Removed references to CPU pressure node condition and evictions. - Added note about new --cpu-manager-reconcile-period flag. - Added note about node allocatable requirements for static policy. - Noted limitation of alpha static cpumanager. * Move cpu-manager task link to rsc mgmt section. * init containers annotation removed in 1.8 (#5390) * Add documentation for TaintNodesByCondition (#5352) * Add documentation for TaintNodesByCondition * Update nodes.md * Update taint-and-toleration.md * Update daemonset.md * Update nodes.md * Update taint-and-toleration.md * Update daemonset.md * Fix deployments (#5421) * Document extended resources and OIR deprecation. (#5399) * Document extended resources and OIR deprecation. * Updated extended resources doc per reviews. * reverts extra spacing in _data/tasks.yml * addresses `kubeadm upgrade` review comments Feedback from @chenopis, @luxas, and @steveperry-53 addressed with this commit * HugePages documentation (#5419) * Update cpu-management-policies.md (#5407) Fixed the bad link. Modified "cpu" to "CPU". Added more 'yaml' as supplement. * Update RBAC docs for v1 (#5445) * Add user docs for pod priority and preemption (#5328) * Add user docs for pod priority and preemption * Update pod-priority-preemption.md * More updates * Update docs/admin/kubeadm.md for 1.8 (#5440) - Made a couple of minor wording changes (not strictly 1.8 related). - Did some reformatting (not strictly 1.8 related). - Updated references to the default token TTL (was infinite, now 24 hours). - Documented the new `--discovery-token-ca-cert-hash` and `--discovery-token-unsafe-skip-ca-verification` flags for `kubeadm join`. - Added references to the new `--discovery-token-ca-cert-hash` flag in all the default examples. - Added a new _Security model_ section that describes the security tradeoffs of the various discovery modes. - Documented the new `--groups` flag for `kubeadm token create`. - Added a note of caution under _Automating kubeadm_ that references the _Security model_ section. - Updated the component version table to drop 1.6 and add 1.8. - Update `_data/reference.yml` to try to get the sidebar fixed up and more consistent with `kubefed`. * Update StatefulSet Basics for 1.8 release (#5398) * addresses `kubeadm upgrade` review comments 2nd iteration review comments by @luxas * adds kubelet upgrade section to kubeadm upgrade * Fix a bulleted list on docs/admin/kubeadm.md. (#5458) I updated this doc yesterday and I was absolutely sure I fixed this, but I just saw that this commit got lost somehow. This was introduced recently in #5440. * Clarify the API to check for device plugins * Moving Flexvolume to separate out-of-tree section * addresses `kubeadm upgrade` review comments CC: @luxas * fixes kubeadm upgrade index * Update Stackdriver Logging documentation (#5495) * Re-update WordPress and MySQL PV doc to use apps/v1beta2 APIs (#5526) * Update statefulset concepts doc to use apps/v1beta2 APIs (#5420) * add document on kubectl's behavior regarding initializers (#5505) * Update docs/admin/kubeadm.md to cover self-hosting in 1.8. (#5497) This is a new beta feature in 1.8. * Update kubectl patch doc to use apps/v1beta2 APIs (#5422) * [1.8] Update "Run Applications" tasks to apps/v1beta2. (#5525) * Update replicated stateful application task for 1.8. * Update single instance stateful app task for 1.8. * Update stateless app task for 1.8. * Update kubectl patch task for 1.8. * fix the link of persistent storage (#5515) * update the admission-controllers.md index.md what-is-kubernetes.md link * fix the link of persistent storage * Add quota support for local ephemeral storage (#5493) * Add quota support for local ephemeral storage update the doc to this alpha feature * Update resource-quotas.md * Updated Deployments concepts doc (#5491) * Updated Deployments concepts doc * Addressed comments * Addressed more comments * Modify allocatable storage to ephemeral-storage (#5490) Update the doc to use ephemeral-storage instead of storage * Revamped concepts doc for ReplicaSet (#5463) * Revamped concepts doc for ReplicaSet * Minor changes to call out specific versions for selector defaulting and immutability * Addressed doc review comments * Remove petset documentations (#5395) * Update docs to use batch/v1beta1 cronjobs (#5475) * add federation job doc (#5485) * add federation job doc * Update job.md Edits for clarity and consistency * Update job.md Fixed a typo * update DaemonSet concept for 1.8 release (#5397) * update DaemonSet concept for 1.8 release * Update daemonset.md Fix typo. than -> then * Update bootstrap tokens doc for 1.8. (#5479) * Update bootstrap tokens doc for 1.8. This has some changes I missed when I was updating the main kubeadm documention: - Bootstrap tokens are now beta, not alpha (kubernetes/enhancements#130) - The apiserver flag to enable the authenticator changedin 1.8 (kubernetes/kubernetes#51198) - Added `auth-extra-groups` documentaion (kubernetes/kubernetes#50933) - Updated the _Token Management with `kubeadm`_ section to link to the main kubeadm docs, since it was just duplicated information. * Update bootstrap-tokens.md * Updated the Cassandra tutorial to use apps/v1beta2 (#5548) * add docs for AllowPrivilegeEscalation (#5448) Signed-off-by: Jess Frazelle <acidburn@microsoft.com> * Add local ephemeral storage alpha feature in managing compute resource (#5522) * Add local ephemeral storage alpha feature in managing compute resource Since 1.8, we add the local ephemeral storage alpha feature as one resource type to manage. Add this feature into the doc. * Update manage-compute-resources-container.md * Update manage-compute-resources-container.md * Update manage-compute-resources-container.md * Update manage-compute-resources-container.md * Update manage-compute-resources-container.md * Update manage-compute-resources-container.md * Added documentation for Metrics Server (#5560) * authorization: improve authorization debugging docs (#5549) * Document mount propagation (#5544) * Update /docs/setup/independent/create-cluster-kubeadm.md for 1.8. (#5524) This introduction needed a couple of small tweaks to cover the `--discovery-token-ca-cert-hash` flag added in kubernetes/kubernetes#49520 and some version bumps. * Add task doc for alpha dynamic kubelet configuration (#5523) * Fix input/output of selfsubjectaccess review (#5593) * Add docs for implementing resize (#5528) * Add docs for implementing resize * Update admission-controllers.md * Added link to PVC section * minor typo fixes * Update NetworkPolicy concept guide with egress and CIDR changes (#5529) * update zookeeper tutorial for 1.8 release * add doc for hostpath type (#5503) * Federated Hpa feature doc (#5487) * Federated Hpa feature doc * Federated Hpa feature doc review fixes * Update hpa.md * Update hpa.md * update cloud controller manager docs for v1.8 * Update cronjob with defaults information (#5556) * Kubernetes 1.8 reference docs (#5632) * Kubernetes 1.8 reference docs * Kubectl reference docs for 1.8 * Update side bar with 1.8 kubectl and api ref docs links * remove petset.md * update on state of HostAlias in 1.8 with hostNetwork Pod support (#5644) * Fix cron job deletion section (#5655) * update imported docs (#5656) * Add documentation for certificate rotation. (#5639) * Link to using kubeadm page * fix the command output fix the command output * fix typo in api/resources reference: "Worloads" * Add documentation for certificate rotation. * Create TOC entry for cloud controller manager. (#5662) * Updates for new versions of API types * Followup 5655: fix link to garbage collection (#5666) * Temporarily redirect resources-reference to api-reference. (#5668) * Update config for 1.8 release. (#5661) * Update config for 1.8 release. * Address reviewer comments. * Switch references in HPA docs from alpha to beta (#5671) The HPA docs still referenced the alpha version. This switches them to talk about v2beta1, which is the appropriate version for Kubernetes 1.8 * Deprecate openstack heat (#5670) * Fix typo in pod preset conflict example Move container port definition to the correct line. * Highlight openstack-heat provider deprecation The openstack-heat provider for kube-up is being deprecated and will be removed in a future release. * Temporarily fix broken links by redirecting. (#5672) * Fix broken links. (#5675) * Fix render of code block (#5674) * Fix broken links. (#5677) * Add a small note about auto-bootstrapped CSR ClusterRoles (#5660) * Update kubeadm install doc for v1.8 (#5676) * add draft workloads api content for 1.8 (#5650) * add draft workloads api content for 1.8 * edits per review, add tables, for 1.8 workloads api doc * fix typo * Minor fixes to kubeadm 1.8 upgrade guide. (#5678) - The kubelet upgrade instructions should be done on every host, not just worker nodes. - We should just upgrade all packages, instead of calling out kubelet specifically. This will also upgrade kubectl, kubeadm, and kubernetes-cni, if installed. - Draining nodes should also ignore daemonsets, and master errors can be ignored. - Make sure that the new kubeadm download is chmoded correctly. - Add a step to run `kubeadm version` to verify after downloading. - Manually approve new kubelet CSRs if rotation is enabled (known issue). * Release 1.8 (#5680) * Fix versions for 1.8 API ref docs * Updates for 1.8 kubectl reference docs * Kubeadm /docs/admin/kubeadm.md cleanup, editing. (#5681) * Update docs/admin/kubeadm.md (mostly 1.8 related). This is Fabrizio's work, which I'm committing along with my edits (in a commit on top of this). * A few of my own edits to clarify and clean up some Markdown.

k8s-ci-robot added sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 23, 2017

k8s-github-robot assigned sttts and wojtek-t Aug 23, 2017

k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Aug 23, 2017

luxas approved these changes Aug 23, 2017

View reviewed changes

k8s-ci-robot added the sig/auth Categorizes an issue or PR as relevant to SIG Auth. label Aug 23, 2017

luxas added this to the v1.8 milestone Aug 23, 2017

luxas assigned luxas and ericchiang Aug 23, 2017

mattmoyer force-pushed the rename-experimental-bootstrap-token-auth branch from f1b4688 to 88fab31 Compare August 23, 2017 15:17

liggitt reviewed Aug 23, 2017

View reviewed changes

mattmoyer force-pushed the rename-experimental-bootstrap-token-auth branch from 88fab31 to 9dad15e Compare August 23, 2017 16:06

k8s-ci-robot assigned liggitt Aug 23, 2017

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 23, 2017

k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 23, 2017

k8s-github-robot merged commit 432790d into kubernetes:master Aug 24, 2017

mattmoyer deleted the rename-experimental-bootstrap-token-auth branch August 24, 2017 18:32

luxas mentioned this pull request Aug 26, 2017

--enable-bootstrap-token-auth=true should be set when using v1.8.0-beta.0 or higher kubernetes/kubeadm#414

Closed

mattmoyer mentioned this pull request Sep 15, 2017

Update bootstrap tokens doc for 1.8. kubernetes/website#5479

Merged

mattmoyer added a commit to mattmoyer/kubernetes that referenced this pull request Sep 15, 2017

Drop --experimental-bootstrap-token-auth flag.

9bb322f

This flag was replaced by `--enable-bootstrap-token-auth` in 1.8 (kubernetes#51198).

mattmoyer mentioned this pull request Sep 15, 2017

Drop --experimental-bootstrap-token-auth flag. #52551

Merged

ericchiang mentioned this pull request Oct 23, 2017

change alpha-endpoint-reconciler-type argument to endpoint-reconciler-type #54419

Merged

ericchiang mentioned this pull request Mar 20, 2018

Promote encryption at rest with static configs to beta #61420

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

kubeapiserver: rename `--experimental-bootstrap-token-auth` to `--enable-bootstrap-token-auth`. #51198

kubeapiserver: rename `--experimental-bootstrap-token-auth` to `--enable-bootstrap-token-auth`. #51198

mattmoyer commented Aug 23, 2017 •

edited

Loading

luxas left a comment

luxas Aug 23, 2017

mattmoyer Aug 23, 2017

luxas commented Aug 23, 2017

liggitt Aug 23, 2017

mattmoyer Aug 23, 2017

liggitt Aug 23, 2017

liggitt commented Aug 23, 2017

k8s-github-robot commented Aug 23, 2017

mattmoyer commented Aug 24, 2017

mattmoyer commented Aug 24, 2017

mattmoyer commented Aug 24, 2017

k8s-github-robot commented Aug 24, 2017

kubeapiserver: rename --experimental-bootstrap-token-auth to --enable-bootstrap-token-auth. #51198

kubeapiserver: rename --experimental-bootstrap-token-auth to --enable-bootstrap-token-auth. #51198

Conversation

mattmoyer commented Aug 23, 2017 • edited Loading

Example of the warning log:

luxas left a comment

Choose a reason for hiding this comment

luxas Aug 23, 2017

Choose a reason for hiding this comment

mattmoyer Aug 23, 2017

Choose a reason for hiding this comment

luxas commented Aug 23, 2017

liggitt Aug 23, 2017

Choose a reason for hiding this comment

mattmoyer Aug 23, 2017

Choose a reason for hiding this comment

liggitt Aug 23, 2017

Choose a reason for hiding this comment

liggitt commented Aug 23, 2017

k8s-github-robot commented Aug 23, 2017

mattmoyer commented Aug 24, 2017

mattmoyer commented Aug 24, 2017

mattmoyer commented Aug 24, 2017

k8s-github-robot commented Aug 24, 2017

kubeapiserver: rename `--experimental-bootstrap-token-auth` to `--enable-bootstrap-token-auth`. #51198

kubeapiserver: rename `--experimental-bootstrap-token-auth` to `--enable-bootstrap-token-auth`. #51198

mattmoyer commented Aug 23, 2017 •

edited

Loading