Small refactoring around drain - move drain logic to separate function. #24923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-github-robot
added
size/M
k8s-github-robot
added
the
do-not-merge
eparis
removed
the
do-not-merge
|
|
||
| // GetPodsForDeletionOnNodeDrain returns pods that should be deleted on node drain as well as some extra information | ||
| // about possibly problematic pods (unreplicated and deamon sets). | ||
| func GetPodsForDeletionOnNodeDrain(client *client.Client, nodename string, decoder runtime.Decoder, removeUnderplicated bool, |
There was a problem hiding this comment.
removeUnderplicated: did you mean removeUnreplicated (typo)?
There was a problem hiding this comment.
The whole purpose of this refactoring is to make it public :).
Other comments applied.
janetkuo
added
release-note-none
janetkuo
added
the
lgtm
|
LGTM now. Thanks! |
|
cc @mml |
piosz
added
the
priority/important-soon
|
Bumped priority, cluster autoscaler in a blocker for 1.3 |
|
GCE e2e build/test passed for commit 60f1339. |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e build/test passed for commit 60f1339. |
|
Automatic merge from submit-queue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc: @piosz @fgrzadkowski