WIP: Change the repo to use glide instead of godep #24202

thockin · 2016-04-13T15:37:05Z

NO NOT MERGE

Switch to glide as our dependency manager. It seems more friendly and more stable than godep, and the glide developers are actively improving the UX. This assumes that we're using go-1.6 (or go-1.5 with GO15VENDOREXPERIMENT=1) and not go-1.4.

Most of this PR is moving deps around. The interesting parts are in the "glide init" and "convert everything" commits.

Open issues:

a bug in glide makes getting new packages fail in this config
godep licenses stuff needs to be ported
jenkins stuff needs to be ported
need to finish doc changes
needs more testing

This change is

glide install --delete --force --update-vendored --strip-vcs --strip-vendor Many conflicts were flagged, we can examine them later.

thockin · 2016-04-13T15:37:52Z

@vishh @madhusudancs @eparis @mikedanese

I filed it as a PR so nobody repeats the work. Not quite ready for prime time, though

k8s-github-robot · 2016-04-13T21:40:14Z

@thockin PR needs rebase

lavalamp · 2016-05-09T21:40:19Z

looks good so far. Let me know if I can help.

thockin · 2016-05-10T06:12:14Z

I'll wait for the glide guys to fix a couple of bugs we need fixed and then
rebase this against head, now that we have moved to a vendor/ dir.

On Mon, May 9, 2016 at 2:40 PM, Daniel Smith notifications@github.com
wrote:

looks good so far. Let me know if I can help.

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#24202 (comment)

k8s-bot · 2016-05-23T18:28:33Z

GCE e2e build/test failed for commit 3316388.

Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake.

k8s-bot · 2016-07-06T15:12:03Z

Build finished. No test results found.

lavalamp · 2016-07-08T16:36:39Z

Please assign back when it's ready for review.

vladimirvivien · 2016-07-19T21:46:38Z

@thockin is this targeting k8s 1.4 or later ?

thockin · 2016-07-20T22:26:02Z

It's really dependent on the glide folks fixing a bunch of issues.

On Tue, Jul 19, 2016 at 2:47 PM, Vladimir Vivien notifications@github.com
wrote:

@thockin https://github.com/thockin is this targeting 1.4 or later ?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#24202 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFVgVKZm6jalnlKxG-t-DXLwtYF0gh6bks5qXUXugaJpZM4IGhbm
.

vishh · 2016-07-20T22:49:37Z

I really wish we can stop using godep soon. A lot of us, including me, have
wasted incredible amounts of time due to godep.
I really wish k8s community picks up either godep or glide and updates
it as necessary to meet k8s requirements.

On Wed, Jul 20, 2016 at 3:26 PM, Tim Hockin notifications@github.com
wrote:

It's really dependent on the glide folks fixing a bunch of issues.

On Tue, Jul 19, 2016 at 2:47 PM, Vladimir Vivien <notifications@github.com

wrote:

@thockin https://github.com/thockin is this targeting 1.4 or later ?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<
#24202 (comment)
,
or mute the thread
<
https://github.com/notifications/unsubscribe-auth/AFVgVKZm6jalnlKxG-t-DXLwtYF0gh6bks5qXUXugaJpZM4IGhbm

.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#24202 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGvIKI7CNj6Rkw3PkKkcznHTbED_aKZDks5qXqCfgaJpZM4IGhbm
.

thockin · 2016-07-20T22:58:22Z

Not for lack of want.

On Jul 20, 2016 3:50 PM, "Vish Kannan" notifications@github.com wrote:

I really wish we can stop using godep soon. A lot of us, including me, have
wasted incredible amounts of time due to godep.
I really wish k8s community picks up either godep or glide and updates
it as necessary to meet k8s requirements.

On Wed, Jul 20, 2016 at 3:26 PM, Tim Hockin notifications@github.com
wrote:

It's really dependent on the glide folks fixing a bunch of issues.

On Tue, Jul 19, 2016 at 2:47 PM, Vladimir Vivien <
notifications@github.com

wrote:

@thockin https://github.com/thockin is this targeting 1.4 or later ?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<

#24202 (comment)

,
or mute the thread
<

https://github.com/notifications/unsubscribe-auth/AFVgVKZm6jalnlKxG-t-DXLwtYF0gh6bks5qXUXugaJpZM4IGhbm

.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<
#24202 (comment)
,
or mute the thread
<
https://github.com/notifications/unsubscribe-auth/AGvIKI7CNj6Rkw3PkKkcznHTbED_aKZDks5qXqCfgaJpZM4IGhbm

.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#24202 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFVgVCKh-WS_kQnx_cpLPcyfGVxsG1oIks5qXqYxgaJpZM4IGhbm
.

jessfraz · 2016-07-25T20:34:19Z

yay glide, let me know if I can help the switch in anyway cuz I have feelings about godep hahaha

jessfraz · 2016-07-25T20:34:48Z

do we have a list of the glide issues we are waiting on?

thockin · 2016-07-25T21:02:19Z

Look at issues I filed against glide. Basically, importing worked great,
but updates and other ops fell over.

On Jul 25, 2016 1:35 PM, "Jess Frazelle" notifications@github.com wrote:

do we have a list of the glide issues we are waiting on?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#24202 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFVgVK9b5CP-syL4IWBD3ldQBNLvXE2sks5qZR4ZgaJpZM4IGhbm
.

jessfraz · 2016-07-25T22:04:16Z

I won't try to start a bike shed but I use gvt on all my repos and it works super intuitively https://github.com/FiloSottile/gvt also it's less ruby-esque since it doesn't have a lock file and uses the native golang manifest stuff, I do think the go team is working on fixing vendoring in general in 1.8 with something official so maybe we should just hold off entirely? idk

justinsb · 2016-10-27T15:57:10Z

With @mikedanese 's amazing bazel work, I think it is worth revisiting this problem. gazel can exclude the vendor directories from our vendored dependencies. git submodules become even easier (for example).

There are two ways to use git submodules:

use git submodules directly (one per dependency). This does require github to be online during the initial clone.
use git submodules into an ignored directory (_vendor) which we then copy into a directory which we commit to version control. This allows us to exclude vendor/**/vendor dirs, which may be clearer and support non-bazel build tools.

AlmogBaku · 2016-11-20T13:40:03Z

@justinsb glide is a working solution which is quite common in the go community... i don't understand why we should use gazelle for doing that.. especially when other k8s projects are already using it.

@thockin I believe glide is more than stable to give it a new try.. how can we push this forward?

nhlfr · 2016-11-20T14:03:40Z

I'd also suggest to ignore vendor/ dir, regardless whether glide or gazel will be used - it is possible with glide, helm is already doing that.

thockin · 2016-11-20T21:27:06Z

To push this forward, someone needs to do the work - convert it to glide,
convert all scripts and docs to describe glide, and convince me that the
new state is equivalent. Also, since glide lists conflicts more verbosely,
provide a list of those for consideration.

On Sun, Nov 20, 2016 at 5:40 AM, Almog Baku notifications@github.com
wrote:

@justinsb https://github.com/justinsb glide is a working solution which
is quite common in the go community... i don't understand why we should use
gazelle for doing that.. especially when other k8s projects are already
using it.

@thockin https://github.com/thockin I believe glide is more than stable
to give it a new try.. how can we push this forward?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#24202 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFVgVIa4LXJGgYAyVuxVbjkzpsvcLEt_ks5rAE3EgaJpZM4IGhbm
.

AlmogBaku · 2016-11-21T00:10:58Z

Fair enough. So I guess this PR is too outdated?
Can we open an issue that describe the issue in more details/with todo list?

On Sun, Nov 20, 2016 at 11:27 PM, Tim Hockin notifications@github.com
wrote:

To push this forward, someone needs to do the work - convert it to glide,
convert all scripts and docs to describe glide, and convince me that the
new state is equivalent. Also, since glide lists conflicts more verbosely,
provide a list of those for consideration.

On Sun, Nov 20, 2016 at 5:40 AM, Almog Baku notifications@github.com
wrote:

@justinsb https://github.com/justinsb glide is a working solution
which
is quite common in the go community... i don't understand why we should
use
gazelle for doing that.. especially when other k8s projects are already
using it.

@thockin https://github.com/thockin I believe glide is more than
stable
to give it a new try.. how can we push this forward?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<https://github.com/kubernetes/kubernetes/pull/
24202#issuecomment-261778976>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/
AFVgVIa4LXJGgYAyVuxVbjkzpsvcLEt_ks5rAE3EgaJpZM4IGhbm>

.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#24202 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAGCpjgG04f_jU9jC5sXiqQdtllbKUIfks5rALs_gaJpZM4IGhbm
.

http://www.rimoto.net/

www.rimoto.com http://www.rimoto.net/

Almog Baku

CTO & Cofounder *
Mobile: +972.50.2288.744
Social: * http://www.facebook.com/AlmogBaku
http://www.linkedin.com/in/almogbaku

thockin · 2016-11-21T00:13:48Z

If someone gets the energy for this - just try it. See what works and what
still doesn't. Update a dependency - does it work sanely? Document it.
This PR has a lot of valuable notes, but is pretty obsolete as a whole.

On Sun, Nov 20, 2016 at 4:11 PM, Almog Baku notifications@github.com
wrote:

Fair enough. So I guess this PR is too outdated?
Can we open an issue that describe the issue in more details/with todo
list?

On Sun, Nov 20, 2016 at 11:27 PM, Tim Hockin notifications@github.com
wrote:

To push this forward, someone needs to do the work - convert it to glide,
convert all scripts and docs to describe glide, and convince me that the
new state is equivalent. Also, since glide lists conflicts more
verbosely,
provide a list of those for consideration.

On Sun, Nov 20, 2016 at 5:40 AM, Almog Baku notifications@github.com
wrote:

@justinsb https://github.com/justinsb glide is a working solution
which
is quite common in the go community... i don't understand why we should
use
gazelle for doing that.. especially when other k8s projects are already
using it.

@thockin https://github.com/thockin I believe glide is more than
stable
to give it a new try.. how can we push this forward?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<https://github.com/kubernetes/kubernetes/pull/
24202#issuecomment-261778976>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/
AFVgVIa4LXJGgYAyVuxVbjkzpsvcLEt_ks5rAE3EgaJpZM4IGhbm>

.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<https://github.com/kubernetes/kubernetes/pull/
24202#issuecomment-261807059>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAGCpjgG04f_
jU9jC5sXiqQdtllbKUIfks5rALs_gaJpZM4IGhbm>
.

http://www.rimoto.net/

www.rimoto.com http://www.rimoto.net/

Almog Baku

CTO & Cofounder *
Mobile: +972.50.2288.744
Social: * http://www.facebook.com/AlmogBaku
http://www.linkedin.com/in/almogbaku

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#24202 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFVgVOaKJrmouI9ma6RNg9S59NhqPCgMks5rAOGzgaJpZM4IGhbm
.

timoreimann · 2016-11-21T05:28:56Z

FWIW, 4 of the 9 issues @thockin filed with the glide project are still open.

thockin · 2016-11-21T05:41:12Z

They may be obsolete now - it's worth revisiting.

On Sun, Nov 20, 2016 at 9:29 PM, Timo Reimann notifications@github.com
wrote:

FWIW, 4 of the 9 issues @thockin https://github.com/thockin filed with
the glide project are still open
https://github.com/Masterminds/glide/issues/created_by/Thockin.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#24202 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFVgVGms_SxVDT9SDtmTKMpxUWttpOwyks5rASwngaJpZM4IGhbm
.

nhlfr · 2016-11-28T21:53:02Z

There is one big problem with making k8s compatible with glide. We are doing symlink in vendor/k8s.io/client-go. Why is it problematic? Every time when you're running glide install, the whole vendor/ dir is cleaned and only repositories fetched by glide are putted there.

thockin · 2016-11-28T23:16:06Z

I think that symlink is a transitional thing, and we can fix up the glide process to restore it (wrap in a shell script if need be)

thockin · 2016-11-28T23:16:14Z

@caesarxuchao

caesarxuchao · 2016-11-28T23:59:02Z

I think that symlink is a transitional thing, and we can fix up the glide process to restore it (wrap in a shell script if need be)

Yes, it's transitional, though we have several steps to go before removing it.

We already had a script for godep save. It sets up the symlink.

thockin · 2016-11-29T00:14:59Z

So a change to glide would need to replicate that step.

…

On Mon, Nov 28, 2016 at 3:59 PM, Chao Xu ***@***.***> wrote: I think that symlink is a transitional thing, and we can fix up the glide process to restore it (wrap in a shell script if need be) Yes, it's transitional, though we have several steps to go before removing it. We already had a script for godep save. It sets up the symlink <https://github.com/kubernetes/kubernetes/blob/master/hack/godep-save.sh#L42> . — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#24202 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFVgVMDxcf_ZjXr37TD8KqBp37FfHeitks5rC2rWgaJpZM4IGhbm> .

k8s-github-robot · 2016-12-01T01:16:03Z

Adding label:do-not-merge because PR changes docs prohibited to auto merge
See http://kubernetes.io/editdocs/ for information about editing docs

k8s-github-robot · 2017-01-23T22:05:24Z

[APPROVALNOTIFIER] Needs approval from an approver in each of these OWNERS Files:

OWNERS

We suggest the following people:
cc @brendandburns
You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

k8s-github-robot · 2017-01-30T22:41:51Z

This PR hasn't been active in 62 days. It will be closed in 27 days (Feb 27, 2017).

cc @thockin

You can add 'keep-open' label to prevent this from happening, or add a comment to keep it open another 90 days

…upstreams-jsafrane Bug 1776351: Restore UPSTREAMs dropped in kubernetes#24159 Origin-commit: 1573ab247c4cf86b4466e336dd904b6f3039f1bd

…upstreams-jsafrane Bug 1776351: Restore UPSTREAMs dropped in kubernetes#24159

thockin added 3 commits April 12, 2016 15:35

run 'glide init'

1c58740

Run glide install ...

098e98c

glide install --delete --force --update-vendored --strip-vcs --strip-vendor Many conflicts were flagged, we can examine them later.

remove errant ''' string in glide.yaml

37b77a3

googlebot added the cla: yes label Apr 13, 2016

k8s-github-robot assigned lavalamp Apr 13, 2016

k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Apr 13, 2016

k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 13, 2016

thockin added 2 commits April 13, 2016 23:39

WIP: convert everything

44ea1d5

Remove Godeps/...

3316388

thockin force-pushed the glide branch from d56ca46 to 3316388 Compare April 14, 2016 06:39

k8s-github-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 18, 2016

lavalamp assigned thockin and unassigned lavalamp Jul 8, 2016

lxfontes mentioned this pull request Nov 1, 2016

Glide Shopify/ejson#32

Merged

k8s-github-robot added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Nov 10, 2016

apelisse removed the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Nov 11, 2016

k8s-github-robot added the kind/old-docs label Dec 1, 2016

k8s-github-robot added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Dec 1, 2016

k8s-github-robot assigned ixdy and unassigned thockin Jan 30, 2017

k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2017

apelisse assigned thockin Jan 31, 2017

thockin closed this Jan 31, 2017

songbinliu mentioned this pull request Sep 21, 2017

Change the repo to use glide instead of godep turbonomic/kubeturbo#109

Closed

thockin deleted the glide branch August 14, 2019 17:46

p0lyn0mial pushed a commit to p0lyn0mial/kubernetes that referenced this pull request Dec 20, 2019

Merge pull request kubernetes#24202 from sttts/sttts-restore-dropped-…

0c0e943

…upstreams-jsafrane Bug 1776351: Restore UPSTREAMs dropped in kubernetes#24159

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIP: Change the repo to use glide instead of godep #24202

WIP: Change the repo to use glide instead of godep #24202

thockin commented Apr 13, 2016 •

edited by k8s-oncall

Loading

thockin commented Apr 13, 2016

k8s-github-robot commented Apr 13, 2016

lavalamp commented May 9, 2016

thockin commented May 10, 2016

k8s-bot commented May 23, 2016

k8s-bot commented Jul 6, 2016

lavalamp commented Jul 8, 2016

vladimirvivien commented Jul 19, 2016 •

edited

Loading

thockin commented Jul 20, 2016

vishh commented Jul 20, 2016

thockin commented Jul 20, 2016

jessfraz commented Jul 25, 2016

jessfraz commented Jul 25, 2016

thockin commented Jul 25, 2016

jessfraz commented Jul 25, 2016

justinsb commented Oct 27, 2016

AlmogBaku commented Nov 20, 2016

nhlfr commented Nov 20, 2016

thockin commented Nov 20, 2016

AlmogBaku commented Nov 21, 2016

thockin commented Nov 21, 2016

timoreimann commented Nov 21, 2016

thockin commented Nov 21, 2016

nhlfr commented Nov 28, 2016

thockin commented Nov 28, 2016

thockin commented Nov 28, 2016

caesarxuchao commented Nov 28, 2016

thockin commented Nov 29, 2016 via email

k8s-github-robot commented Dec 1, 2016

k8s-github-robot commented Jan 23, 2017

k8s-github-robot commented Jan 30, 2017

WIP: Change the repo to use glide instead of godep #24202

WIP: Change the repo to use glide instead of godep #24202

Conversation

thockin commented Apr 13, 2016 • edited by k8s-oncall Loading

thockin commented Apr 13, 2016

k8s-github-robot commented Apr 13, 2016

lavalamp commented May 9, 2016

thockin commented May 10, 2016

k8s-bot commented May 23, 2016

k8s-bot commented Jul 6, 2016

lavalamp commented Jul 8, 2016

vladimirvivien commented Jul 19, 2016 • edited Loading

thockin commented Jul 20, 2016

vishh commented Jul 20, 2016

thockin commented Jul 20, 2016

jessfraz commented Jul 25, 2016

jessfraz commented Jul 25, 2016

thockin commented Jul 25, 2016

jessfraz commented Jul 25, 2016

justinsb commented Oct 27, 2016

AlmogBaku commented Nov 20, 2016

nhlfr commented Nov 20, 2016

thockin commented Nov 20, 2016

AlmogBaku commented Nov 21, 2016

thockin commented Nov 21, 2016

timoreimann commented Nov 21, 2016

thockin commented Nov 21, 2016

nhlfr commented Nov 28, 2016

thockin commented Nov 28, 2016

thockin commented Nov 28, 2016

caesarxuchao commented Nov 28, 2016

thockin commented Nov 29, 2016 via email

k8s-github-robot commented Dec 1, 2016

k8s-github-robot commented Jan 23, 2017

k8s-github-robot commented Jan 30, 2017

thockin commented Apr 13, 2016 •

edited by k8s-oncall

Loading

vladimirvivien commented Jul 19, 2016 •

edited

Loading