KEP-4292: Add e2e test for custom profile in kubectl debug #127187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
ardaguclu
force-pushed
the
promote-4292-ga
branch
3 times, most recently
from
30a6a9d to
4420f7f
Compare
ardaguclu
force-pushed
the
promote-4292-ga
branch
from
4420f7f to
1749e29
Compare
ardaguclu
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
12 tasks
soltysh
requested changes
Oct 1, 2024
k8s-ci-robot
added
the
do-not-merge/hold
|
/label tide/merge-method-squash |
k8s-ci-robot
added
the
tide/merge-method-squash
|
I think, this is ready to merge; |
k8s-ci-robot
removed
the
do-not-merge/hold
soltysh
reviewed
Oct 21, 2024
test/e2e/kubectl/debug.go
Outdated
| framework.ExpectNoError(err) | ||
| output := e2ekubectl.RunKubectlOrDie(ns, "get", "pod", debugPodName, "-o", "jsonpath={.spec.ephemeralContainers[*]}") | ||
| ginkgo.By("verifying NET_ADMIN is added") | ||
| if !strings.Contains(output, "NET_ADMIN") { |
There was a problem hiding this comment.
Change all three conditions to use this form:
gomega.Expect(output).To(gomega.MatchError(gomega.ContainSubstring("NET_ADMIN")))
which on error will provide more explainable output, see here for reference.
There was a problem hiding this comment.
Used in this form;
gomega.Expect(output).To(gomega.ContainSubstring("NET_ADMIN"))| customProfileFile := "custom.yaml" | ||
| framework.ExpectNoError(err) | ||
| defer os.Remove(tmpDir) //nolint:errcheck | ||
| framework.ExpectNoError(os.WriteFile(filepath.Join(tmpDir, customProfileFile), []byte(` |
There was a problem hiding this comment.
Please make sure to add an explanation to the framework.ExpectNoError(err error, explain ...interface{}) invocation, that is then helpful when debugging problems. See my other comment for reference.
There was a problem hiding this comment.
Added. Hope it is explanatory.
test/e2e/kubectl/debug.go
Outdated
| "sleep 3600") | ||
|
|
||
| ginkgo.By("verifying the container debugger is running") | ||
| err = wait.PollUntilContextTimeout(ctx, 3*time.Second, 2*time.Minute, false, func(ctx context.Context) (bool, error) { |
There was a problem hiding this comment.
How about using WaitForPodContainerStarted from k8s.io/kubernetes/test/e2e/framework/pod?
There was a problem hiding this comment.
After your suggestion, I've found a better one WaitForPodsWithLabelRunning since I'm focusing on the running status
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 0fb80ec427eba62e3ac8942145a07e1567a013f1
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ardaguclu, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
scott-grimes
pushed a commit
to scott-grimes/kubernetes
that referenced
this pull request
Oct 23, 2024
…s#127187) * Remove KUBECTL_DEBUG_CUSTOM_PROFILE env var * Add e2e test for custom profile in kubectl debug * Keep feature flag until 1.33 * Update comment * Simplify tests by relying on test framework functionality * Rename import alias to better to pass verify-import-alias
richabanker
pushed a commit
to richabanker/kubernetes
that referenced
this pull request
Oct 29, 2024
…s#127187) * Remove KUBECTL_DEBUG_CUSTOM_PROFILE env var * Add e2e test for custom profile in kubectl debug * Keep feature flag until 1.33 * Update comment * Simplify tests by relying on test framework functionality * Rename import alias to better to pass verify-import-alias
felipeagger
pushed a commit
to felipeagger/kubernetes
that referenced
this pull request
Nov 6, 2024
…s#127187) * Remove KUBECTL_DEBUG_CUSTOM_PROFILE env var * Add e2e test for custom profile in kubectl debug * Keep feature flag until 1.33 * Update comment * Simplify tests by relying on test framework functionality * Rename import alias to better to pass verify-import-alias
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR adds e2e for custom profiling in kubectl debug as promised in enhancement as prerequisite for promotion to stable.
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: