Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cobra to v1.4.0 #108643

Merged
merged 1 commit into from
Mar 11, 2022
Merged

Update cobra to v1.4.0 #108643

merged 1 commit into from
Mar 11, 2022

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Mar 10, 2022

What type of PR is this?

Retread of #107628 on 1.4.0

/kind cleanup
/kind feature

What this PR does / why we need it:

Updates to cobra 1.4.0, picks up features highlighted in #107628, and drops the viper dependency 🎉

Which issue(s) this PR fixes:

Fixes kubernetes/kubectl#1166

Does this PR introduce a user-facing change?

NONE

/sig cli
cc @eddiezane @brianpursley @dims

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. sig/cli Categorizes an issue or PR as relevant to SIG CLI. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 10, 2022
@liggitt liggitt requested a review from eddiezane March 10, 2022 21:21
@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Mar 10, 2022
@liggitt liggitt requested a review from dims March 10, 2022 21:21
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/apiserver area/cloudprovider approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes area/kubectl sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. labels Mar 10, 2022
@k8s-ci-robot k8s-ci-robot requested review from alculquicondor, andrewsykim and a team March 10, 2022 21:22
liggitt
liggitt commented Mar 10, 2022
View reviewed changes
hack/unwanted-dependencies.json
@@ -1,30 +1,30 @@
{
"spec": {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff here is strictly additive, I just sorted the list as well

liggitt
liggitt commented Mar 10, 2022
View reviewed changes
hack/unwanted-dependencies.json
Comment on lines -24 to -27
"github.com/hashicorp/golang-lru",
"github.com/hashicorp/hcl",
"github.com/json-iterator/go",
"github.com/spf13/viper"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

three of these dropped out of our deps list as a result of this :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent!

@liggitt
Copy link
Member Author

liggitt commented Mar 10, 2022

dependency stats:

{
-	"directDependencies": 160,
-	"transitiveDependencies": 307,
-	"totalDependencies": 367,
-	"maxDepthOfDependencies": 30
+	"directDependencies": 161,
+	"transitiveDependencies": 262,
+	"totalDependencies": 323,
+	"maxDepthOfDependencies": 29
 }

transitive: 307 → 262 (-14.6%)

total: 367 → 323 (-11.9%)

@dims
Copy link
Member

dims commented Mar 10, 2022

looks like the only other bump was go-md2man/v2 from v2.0.0 to v2.0.1

Win! Win!

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 10, 2022
@liggitt
Copy link
Member Author

liggitt commented Mar 10, 2022 •
edited
Loading

looks like the only other bump was go-md2man/v2 from v2.0.0 to v2.0.1

and github.com/russross/blackfriday/v2 => github.com/russross/blackfriday/v2 v2.1.0, which was a pre-existing dep

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt
Copy link
Member Author

liggitt commented Mar 10, 2022

/retest

@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@k8s-ci-robot k8s-ci-robot merged commit 9d51258 into kubernetes:master Mar 11, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Mar 11, 2022
@leilajal
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 17, 2022
@marckhouzam marckhouzam mentioned this pull request Mar 17, 2022
Merged
@github-actions github-actions bot mentioned this pull request Mar 22, 2022
Open
@liggitt liggitt deleted the cobra branch May 5, 2022 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddiezane eddiezane Awaiting requested review from eddiezane

@dims dims Awaiting requested review from dims

@alculquicondor alculquicondor Awaiting requested review from alculquicondor

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

Assignees

@dims dims

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/cloudprovider area/dependency Issues or PRs related to dependency changes area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.

Update Cobra to version 1.3.0
5 participants
@liggitt @dims @k8s-ci-robot @k8s-triage-robot @leilajal