Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kinder: add e2e test for WaitForAllControlPlaneComponents #3031

Merged
merged 1 commit into from
Feb 29, 2024
Merged

kinder: add e2e test for WaitForAllControlPlaneComponents #3031

merged 1 commit into from
Feb 29, 2024

Conversation

neolit123
Copy link
Member

@neolit123 neolit123 commented Feb 28, 2024 •
edited
Loading

needs kubernetes/kubernetes#123341 to merge first

test infra PR
kubernetes/test-infra#32098

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 28, 2024
@k8s-ci-robot k8s-ci-robot added the area/kinder Issues to track work in the kinder tool label Feb 28, 2024
@k8s-ci-robot k8s-ci-robot requested a review from SataQiu February 28, 2024 17:50
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 28, 2024
@neolit123 neolit123 added kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kinder Issues to track work in the kinder tool labels Feb 28, 2024
@neolit123 neolit123 added this to the v1.30 milestone Feb 28, 2024
@neolit123 neolit123 added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kinder Issues to track work in the kinder tool labels Feb 28, 2024
This was referenced Feb 28, 2024
Merged
Merged
@neolit123 neolit123 force-pushed the 1.30-add-e2e-for-check-all-components branch from fc5d1ae to 53b22f8 Compare February 28, 2024 17:59
@neolit123 neolit123 force-pushed the 1.30-add-e2e-for-check-all-components branch from 53b22f8 to e87ff14 Compare February 28, 2024 20:20
@neolit123 neolit123 requested review from pacoxu and removed request for chendave February 29, 2024 10:49
pacoxu
pacoxu approved these changes Feb 29, 2024
View reviewed changes
Copy link
Member

@pacoxu pacoxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgmt

@pacoxu
Copy link
Member

pacoxu commented Feb 29, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 29, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neolit123, pacoxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pacoxu
Copy link
Member

pacoxu commented Feb 29, 2024

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 29, 2024
@k8s-ci-robot k8s-ci-robot merged commit 640a714 into kubernetes:main Feb 29, 2024
4 checks passed
@neolit123 neolit123 mentioned this pull request Oct 31, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pacoxu pacoxu pacoxu approved these changes

@SataQiu SataQiu Awaiting requested review from SataQiu

Assignees

@pacoxu pacoxu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kinder Issues to track work in the kinder tool cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.30
Development

Successfully merging this pull request may close these issues.
3 participants
@neolit123 @pacoxu @k8s-ci-robot