-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create opt-in kube_persistentvolume_csi_attributes metric #2133
feat: create opt-in kube_persistentvolume_csi_attributes metric #2133
Conversation
Welcome @machadovilaca! |
/assign @dgrisonnet |
Can you update https://github.com/kubernetes/kube-state-metrics/blob/main/docs/persistentvolume-metrics.md to include the new attribute as well? |
c7b0c08
to
0eee653
Compare
0eee653
to
23e108a
Compare
@dgrisonnet created a new opt-in metric, maybe this is enough to avoid very specific information |
23e108a
to
2866bc8
Compare
Signed-off-by: João Vilaça <jvilaca@redhat.com>
2866bc8
to
e09df21
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dgrisonnet, machadovilaca The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This PR creates a new opt-in
kube_persistentvolume_csi_attributes
metricHow does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality)
It doesn't affect it since the metric is opt-in.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #