-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "kube_horizontalpodautoscaler_info" metric #1648
Merged
k8s-ci-robot
merged 3 commits into
kubernetes:master
from
Serializator:add-kube-horizontalpodautoscaler-info-metric
Dec 9, 2021
Merged
Add "kube_horizontalpodautoscaler_info" metric #1648
k8s-ci-robot
merged 3 commits into
kubernetes:master
from
Serializator:add-kube-horizontalpodautoscaler-info-metric
Dec 9, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
labels
Dec 7, 2021
Serializator
force-pushed
the
add-kube-horizontalpodautoscaler-info-metric
branch
2 times, most recently
from
December 7, 2021 21:39
6d7ac39
to
f5b42be
Compare
/approve |
k8s-ci-robot
added
the
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
label
Dec 7, 2021
fpetkovski
reviewed
Dec 8, 2021
fpetkovski
reviewed
Dec 8, 2021
Serializator
force-pushed
the
add-kube-horizontalpodautoscaler-info-metric
branch
from
December 8, 2021 17:44
f5b42be
to
bb02daf
Compare
k8s-ci-robot
added
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
and removed
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
labels
Dec 8, 2021
/lgtm Nice work |
/lgtm |
k8s-ci-robot
added
the
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
label
Dec 9, 2021
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fpetkovski, mrueg, Serializator The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds a metric which exposes the
scaleTargetRef.apiVersion
,scaleTargetRef.kind
andscaleTargetRef.name
of theHorizontalPodAutoscaler
resource objects in the cluster.How does this change affect the cardinality of KSM:
Which issue(s) this PR fixes:
Fixes #1635