-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the architecture specified in the Makefile for the Docker image and binary #1629
Use the architecture specified in the Makefile for the Docker image and binary #1629
Conversation
Welcome @Serializator! |
Thanks for your contribution! /lgtm |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fpetkovski, mrueg, Serializator The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
What this PR does / why we need it:
Use the distroless image according to the specified architecture from the Makefile and pass the architecture as environment variable to the container which runs
make build-local
so that the binary is built with the correct architecture as well.How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality)
Does not change the cardinality of KSM
Which issue(s) this PR fixes:
Fixes #1615