-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add *_labels metrics for custom resource configurations #1832
Comments
I wonder if this is really something we want. I am personally quite pleased by the fact that users have to define which label they want to use themself since it prevents any unwanted scenarios to occur. Also, we will have to do the same for annotations at some point if we have an option to enable label metrics, and I'd rather keep the configuration format simple with metrics having to be defined manually rather than have some magic mechanisms for some of them. |
Totally fair point, also there is the above example how it could be done using an Allowlist approach 👍 |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
I'll leave this up to get staled / rotten / closed. There were no comments from others requiring this feature. |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close not-planned |
@k8s-triage-robot: Closing this issue, marking it as "Not Planned". In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What would you like to be added:
Allow to expose
*_labels
for Custom Resource configuration which behaves the same askube_*_labels
metrics.This means it would also use the configured value for the flag
--metric-labels-allowlist
for filtering the exposed labels.Why is this needed:
To have the same kind of features for custom resource metrics.
Describe the solution you'd like
One option would be to add a boolean for enabling the labels for a custom resource configuration, e.g. at the
Resource
struct level https://github.com/kubernetes/kube-state-metrics/blob/master/pkg/customresourcestate/config.go#L42Additional context
As of today it would require some custom configuration to expose something like that for a custom resource.
The text was updated successfully, but these errors were encountered: