-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
validate: Expose hooks to inject custom behavior during traversal #406
Conversation
@alexzielenski: GitHub didn't allow me to request PR reviews from the following users: stts. Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @sttts |
e0a1400
to
e957b05
Compare
makes usage consistent with other places, also makes moving to a new index for validation explicit
Looks good to me, Stefan, can you tag it? |
/approve I'll defer to @sttts for lgtm |
Lgtm with exception of https://github.com/kubernetes/kube-openapi/pull/406/files#r1263940329. |
af27688
to
636cf0f
Compare
removed string slice logic |
/label tide/merge-method-squash |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexzielenski, apelisse, jpbetz, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Adds a new Option to the schema validator for users to provider custom constructors for subfield and subindex-validators created during traversal.
/cc @stts @apelisse @jpbetz