Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update amazon cni to 1.3.0 #6128

Merged
merged 1 commit into from
Nov 29, 2018
Merged

Update amazon cni to 1.3.0 #6128

merged 1 commit into from
Nov 29, 2018

Conversation

mikesplain
Copy link
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 28, 2018
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 28, 2018
justinsb
justinsb reviewed Nov 29, 2018
View reviewed changes
upup/models/cloudup/resources/addons/networking.amazon-vpc-routed-eni/k8s-1.10.yaml.template
ports:
- containerPort: 60000
- containerPort: 61678
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why this was changed... any ideas?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like they changed it here, I did a fresh copy and paste to make sure we weren't missing anything with any of the configs.

@justinsb
Copy link
Member

Thanks @mikesplain - I'm not sure why they changed the metrics port, but anyway...

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 29, 2018
@justinsb
Copy link
Member

PS should this be cherry-picked to 1.11 (or others?)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, mikesplain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [justinsb,mikesplain]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 36c06de into kubernetes:master Nov 29, 2018
@mikesplain
Copy link
Contributor Author

Thanks @justinsb! Hmm it's probably best we cherry-pick it in... there are quite a few features people will want in the new version and machine updates. I'll open a PR in a few!

@mikesplain mikesplain deleted the update_amazon_networking_1.3 branch November 29, 2018 16:27
@mikesplain mikesplain mentioned this pull request Nov 29, 2018
Merged
k8s-ci-robot added a commit that referenced this pull request Nov 29, 2018
@k8s-ci-robot
Merge pull request #6132 from mikesplain/automated-cherry-pick-of-#61…
3923146 
…28-origin-release-1.11

Automated cherry pick of #6128: Update amazon cni to 1.3.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinsb justinsb justinsb left review comments

@rdrgmnzs rdrgmnzs Awaiting requested review from rdrgmnzs

@robinpercy robinpercy Awaiting requested review from robinpercy

Assignees

@justinsb justinsb

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikesplain @justinsb @k8s-ci-robot