Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove reconcile flag from kops update #17220

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Remove reconcile flag from kops update #17220

merged 1 commit into from
Jan 20, 2025

Conversation

justinsb
Copy link
Member

We have kops reconcile, and it's confusing having both.

We didn't ship the --reconcile flag in any released version.

@justinsb
Remove reconcile flag from kops update
5c2c304 
We have `kops reconcile`, and it's confusing having both.

We didn't ship the --reconcile flag in any released version.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 20, 2025
@k8s-ci-robot k8s-ci-robot requested a review from zetaab January 20, 2025 15:36
rifelpet
rifelpet approved these changes Jan 20, 2025
View reviewed changes
Copy link
Member

@rifelpet rifelpet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/override pull-kops-e2e-k8s-aws-amazonvpc-u2404

I mistakenly made this new presubmit required instead of optional, fixed in kubernetes/test-infra#34184

@k8s-ci-robot
Copy link
Contributor

@rifelpet: Overrode contexts on behalf of rifelpet: pull-kops-e2e-k8s-aws-amazonvpc-u2404

In response to this:

/override pull-kops-e2e-k8s-aws-amazonvpc-u2404

I mistakenly made this new presubmit required instead of optional, fixed in kubernetes/test-infra#34184

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 20, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2025
@k8s-ci-robot k8s-ci-robot merged commit 30c00ad into kubernetes:master Jan 20, 2025
24 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Jan 20, 2025
@justinsb justinsb mentioned this pull request Jan 21, 2025
Merged
k8s-ci-robot added a commit that referenced this pull request Jan 21, 2025
@k8s-ci-robot
Merge pull request #17226 from justinsb/automated-cherry-pick-of-#172…
0244b37 
…20-release-1.31

Automated cherry pick of #17220: Remove reconcile flag from `kops update`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rifelpet rifelpet rifelpet approved these changes

@olemarkus olemarkus Awaiting requested review from olemarkus

@zetaab zetaab Awaiting requested review from zetaab

Assignees

@rifelpet rifelpet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.32
Development

Successfully merging this pull request may close these issues.
3 participants
@justinsb @k8s-ci-robot @rifelpet