Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include /etc/hosts coredns mounts for dns=none clusters #16347

Merged
merged 2 commits into from
Feb 11, 2024
Merged

Include /etc/hosts coredns mounts for dns=none clusters #16347

merged 2 commits into from
Feb 11, 2024

Conversation

rifelpet
Copy link
Member

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 11, 2024
@k8s-ci-robot k8s-ci-robot requested a review from zetaab February 11, 2024 04:51
@rifelpet
Copy link
Member Author

cc @hakman

You're right, this is more relevant to the failing tests. I'm not sure what the headless services in #16335 are actually used for. Do you happen to know?

rifelpet
rifelpet commented Feb 11, 2024
View reviewed changes
upup/models/cloudup/resources/addons/coredns.addons.k8s.io/k8s-1.12.yaml.template Outdated
@@ -76,7 +76,7 @@ data:
fallthrough in-addr.arpa ip6.arpa
ttl 30
}
{{- if GossipName }}
{{- if not PublishesDNSRecords }}
hosts /rootfs/etc/hosts k8s.local {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold Actually this needs to be updated to the cluster's domain

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold cancel

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 11, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 11, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 11, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 11, 2024
@rifelpet
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit 01f4382 into kubernetes:master Feb 11, 2024
23 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Feb 11, 2024
@rifelpet
Copy link
Member Author

Confirmed this fixed the e2e failures: https://testgrid.k8s.io/kops-grid#kops-grid-calico-flatcar-k28

@BrewTestBot BrewTestBot mentioned this pull request May 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakman hakman hakman approved these changes

@johngmyers johngmyers Awaiting requested review from johngmyers

@zetaab zetaab Awaiting requested review from zetaab

Assignees

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/addons cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.
3 participants
@rifelpet @k8s-ci-robot @hakman