-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set LimitNOFILE to 1048576 instead of infinity
#16329
Set LimitNOFILE to 1048576 instead of infinity
#16329
Conversation
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
infinity should be same as 1048576
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zetaab The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@zetaab thank you, back on its feet https://testgrid.k8s.io/sig-cluster-lifecycle-kops#ci-kubernetes-e2e-al2023-aws-canary&width=20 |
I executed prometheus query |
You honestly shouldn't need to do this if software affected properly raised their soft limit at runtime.
I encourage you to identify the software that hits those issues and push for them to fix it on their end. It's a couple lines to raise the soft limit to the max hard limit. It's not a difficult request to upstream. Why projects like Envoy are refusing to do this is beyond me. |
When we set
LimitNOFILE
toinfinity
things break .. for example the nfs based tests in kubernetes harness:https://testgrid.k8s.io/amazon-ec2-al2023#ci-kubernetes-e2e-al2023-aws-canary&width=20
Also see containerd/containerd#9660 which points to more things that are likely to break with
infinity
containerd/containerd#8924 (comment)