docs: Remove warning about Amazon VPC CNI not being compatible with Ubuntu 22.04 #16326
Conversation
k8s-ci-robot
added
cncf-cla: yes
docs/releases/1.29-NOTES.md
Outdated
| * The Amazon VPC CNI is not compatible with Ubuntu 22.04. See [kubernetes/kops#15720](https://github.com/kubernetes/kops/issues/15720) and [aws/amazon-vpc-cni-k8s#2103](https://github.com/aws/amazon-vpc-cni-k8s/issues/2103) for more info. | ||
|
|
There was a problem hiding this comment.
Please add a note to the AWS section that Amazon VPC CNI is now supported.
There was a problem hiding this comment.
So instead of removing this comment- simply update it?
There was a problem hiding this comment.
Something like that. There are some releases where this is not useable. Some people may be confused.
There was a problem hiding this comment.
No need to keep all links, only a reference to one of the AWS issues should be good.
There was a problem hiding this comment.
Yup, that makes sense!
How's this?
- The Amazon VPC CNI is now compatible with Ubuntu 22.04. Fix applied via kubernetes/kops#16313.
docs/networking/aws-vpc.md
Outdated
| **WARNING**: The Amazon VPC CNI is not compatible with Ubuntu 22.04. See [kubernetes/kops#15720](https://github.com/kubernetes/kops/issues/15720) and [aws/amazon-vpc-cni-k8s#2103](https://github.com/aws/amazon-vpc-cni-k8s/issues/2103) for more info. | ||
|
|
There was a problem hiding this comment.
Please replace this with a note that kOps 1.28.5+.
There was a problem hiding this comment.
@hakman WDYT about the below?
WARNING: The Amazon VPC CNI is not compatible with Ubuntu 22.04 and kOps versions earlier than 1.29. See kubernetes/kops#15720 and aws/amazon-vpc-cni-k8s#2103 for more info (Fix was applied via kubernetes/kops#16313 in kOps 1.29).
hakman
changed the title
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
What this PR does / why we need it:
Following merge of #16313, Amazon VPC CNI is now compatible with Ubuntu 22.04, thus we can remove the warnings across the code.
Special notes for your reviewer:
/cc @hakman
/cc @rifelpet
Hey folks!
I took the liberty of removing the note from 1.29 release notes as well, since it's still in alpha and doesn't have a release branch yet, I hope that's okay.
Also- let me know if ya'll think it's worth backporting #16313 to 1.27 and 1.28 release branches, and I can take care of that.
Thanks! 🙏