-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dumping logs for GCE scale tests #16266
Conversation
/cc @hakman |
@upodroid Please explain in the description what issue you are trying to fix here and how. |
Done |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Splitting #16181 to separate PRs
--dns=none
. Using the IP address is much easier--max-nodes
flag is now respected by the DumpAllNodes function.--ssh-private-key
automatically when running kops gce clusters, this flag must be set for thekops toolbox dump
cmd to work