Re-add net.bridge settings for flannel #13564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
we don't have a flannel / AL2 presubmit job so we wont know if this fixes things until post-merge |
hakman
reviewed
Apr 28, 2022
This was originally only set on Centos 7 / RHEL 7 but we're experiencing similar issues on Amazon Linux 2
hakman
approved these changes
Apr 28, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
lgtm
k8s-ci-robot
added a commit
that referenced
this pull request
Apr 30, 2022
…64-origin-release-1.23 Automated cherry pick of #13564: Re-add net.bridge settings for flannel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was originally only set on Centos 7 / RHEL 7 but we're experiencing similar issues on Amazon Linux 2
backstory:
This PR's lengthy discussion to remove support for flannel/vxlan after the same issues were causing grid failures for Centos 7 / RHEL 7: #8614
These sysctl settings were added for centos/rhel which supposedly fixed our grid jobs: #8381
These settings were removed when we dropped support for those distros: https://github.com/kubernetes/kops/pull/12882/files#diff-5326919ae93590b94b210fb2373f8374d5567d146aadaf815ca6a1f7b68179dd
Hoping this fixes these grid jobs: https://testgrid.k8s.io/kops-grid#kops-grid-flannel-amzn2-k23-docker