[Digital Ocean] Implement Delete Instance logic for rolling update

[srikiz]

Implement delete instance for handling rolling updates.

[k8s-ci-robot]

Hi @srikiz. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[olemarkus]

Have a look at #9927
You may want to merge this into your PR so that rolling update does not require running anything in a second terminal. I think this should work fairly out of the box also with DO.

What I do there is basically just run the full update process in-between terminations.

[srikiz]

@olemarkus - Would it be okay if I merge this separately as a new PR once #9927 is merged?

[olemarkus]

Fine for me :)

[hakman]

In this case, let's try to get #9927 moving. @zetaab do you have some time to look at it?
/ok-to-test
/hold until #9927 is merged

[hakman]

#9927 has been merged.
/hold cancel

[srikiz]

/retest

[olemarkus]

In instancegroups.go there is a function reconcileInstanceGroup(). If you add a check for DO there, rolling updates of DO clusters should work too.

[srikiz]

In instancegroups.go there is a function reconcileInstanceGroup(). If you add a check for DO there, rolling updates of DO clusters should work too.

Okay, I have actually added the check in reconcileInstanceGroup, am I missing something?

[olemarkus]

Sorry, I must have missed that.
/lgtm

[hakman]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman, srikiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [hakman]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment