-
Notifications
You must be signed in to change notification settings - Fork 771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run tests on travis-ci #93
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+1, we just need to check the tests |
👍 @kadel. I will check this after dinner. |
@kadel I tested on ubuntu 16.04.
$ make binary
./script/make.sh binary
---> Making bundle: binary (in .)
Number of parallel builds: 1
--> windows/amd64: github.com/skippbox/kompose/cli/main
--> linux/386: github.com/skippbox/kompose/cli/main
--> darwin/386: github.com/skippbox/kompose/cli/main
--> darwin/amd64: github.com/skippbox/kompose/cli/main
--> linux/amd64: github.com/skippbox/kompose/cli/main
--> windows/386: github.com/skippbox/kompose/cli/main |
ahh my bad 😄 Thank you for noticing that. |
ngtuna
added
the
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
label
Aug 11, 2016
use binary target only for building for current platform
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #34
make test-unit
andmake test-cmd
)make binary
builds only binary for current arch platform where script is running (no cross compiling)make binary-cross
same as formermake binary
(cross compile for mac/linux/win 386/amd65)command line test is failing because of #88 and #92