Ignore links attribute and print warning message

[xianlubird]

Related to issue #859

Signed-off-by: xianlubird@gmail.com

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: helpdesk@rt.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[xianlubird]

CNCF-CLA Done.

[surajnarwade]

@xianlubird , please fix functional test examples accordingly

[xianlubird]

@surajnarwade Done, pls review, thanks.

[cdrage]

Thanks for the awesome contribution! :) Left my review!

[cdrage]

nested if, may be better to do if f.Name() == "Links" && if linksArray := val.FieldByName(f.Name()); linksArray.Kind() == reflect.Slice {

[xianlubird]

Done

[cdrage]

Looking at the code, I don't think this is doing anything? Since findUnsupportedLinksFlag is outside the for i := 0; i < linksArray.Len(); i++ { loop. I could be wrong!

[xianlubird]

Thanks for your review @cdrage .

This flag findUnsupportedLinksFlag is for the above code for _, f := range s.Fields() { at about 100 lines this file.The flag's goal is to find compose links like

  links:
    - 'db:mysql'

which service name is different from alias name. If we find links like this, this flag is set to true and code will process, keysFound = append(keysFound, yamlTagName) this code will append links to keysFound and print warning messsage. But if we have links like this

  links:                                links:
    - redis                              - 'mysql:mysql'

There are many compose like this in our examples and test case folder. For this kind of compose ,we can convert it and shouldn't print any warning message. So in this situation, findUnsupportedLinksFlag will set to false, and links will not be append to keysFound. This code keysFound = append(keysFound, yamlTagName) won't run because we have continue, and code will process next filed.

[cdrage]

Ah, that makes sense. LGTM.

[surajnarwade]

LGTM

[xianlubird]

Thanks for @cdrage @surajnarwade review. So when will this PR be merged ?

[cdrage]

LGTM! was just checking that this works locally on my machine. Mergin'