Add tests for deploy key specifically #727
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cdrage, thank you for the pull request! We'll ping some people to review your PR. @procrypt and @surajnarwade, please review this. |
k8s-ci-robot
added
the
cncf-cla: yes
surajnarwade
approved these changes
Aug 2, 2017
|
I'm going to wait until #738 is merged in before merging this one in since this will create a conflict. |
|
#738 is merged in. Let's wait for these tests to pass and then merge this in. |
Due to: kubernetes@9dcb2bf tests for "replicas" was disabled due to generating "pod-only" kubernetes artifacts as per "restart_policy" being added. This PR adds "deploy" tests so we can effectively test `replicas`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to:
9dcb2bf
tests for "replicas" was disabled due to generating "pod-only"
kubernetes artifacts as per "restart_policy" being added.
This PR adds "deploy" tests so we can effectively test
replicas