Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update quickstart #692

Merged
merged 1 commit into from
Jul 11, 2017
Merged

Update quickstart #692

merged 1 commit into from
Jul 11, 2017

Conversation

cdrage
Copy link
Member

@cdrage cdrage commented Jul 10, 2017

Remove ▶ from CLI commands as well as remove .dab reference.

Remove ▶ from CLI commands as well as remove .dab reference.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 10, 2017
@cdrage cdrage merged commit c16f88a into kubernetes:master Jul 11, 2017
@cdrage
Copy link
Member Author

cdrage commented Jul 11, 2017

Doing a lazy merge (no reviews) in order to incorporate site changes.

@surajssd
Copy link
Member

Why remove the or $ this helps distinguish between the command and it's output?

If you have multiple commands which are shown without any output, there it makes sense to not have $ because the user can copy the block and paste it in terminal.

But when we are showing output i think we should have command starting with $ .

@cdrage
Copy link
Member Author

cdrage commented Jul 18, 2017

@surajssd After discussion, I'm going to re-add the $. You're right. It's confusing and I don't like it either 👎 after viewing it almost-daily when modifying the docs and all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants