Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

delete buildConfig based on label #563

Closed
wants to merge 1 commit into from
Closed

delete buildConfig based on label #563

wants to merge 1 commit into from

Conversation

procrypt
Copy link

BuildConfig was not getting deleted earlier using kompose down.
Fixes #382
@cdrage

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 20, 2017
@procrypt procrypt force-pushed the delete_buildconfig branch 3 times, most recently from 77c51f7 to 88c05f6 Compare April 21, 2017 05:18
@procrypt procrypt force-pushed the delete_buildconfig branch from 88c05f6 to 510dde1 Compare April 21, 2017 05:41
@surajssd
Copy link
Member

This is not the complete solution right because the build pods still remain around. @procrypt let;s keep the discussion here and not on #460 so it's easy to see what all this PR is doing.

@kadel
Copy link
Member

kadel commented Apr 27, 2017 •
edited
Loading

Ah, I didn't noticed this before :-(
I've just submited another PR, that is doing same thing and also solves problem with deleting build pods
#578

@kadel
Copy link
Member

kadel commented May 17, 2017

@procrypt are you OK with closing this PR in favor of #578?

@procrypt
Copy link
Author

@kadel Yeah sure go ahead 👍

@kadel kadel closed this May 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. rebase needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@procrypt @surajssd @kadel @k8s-ci-robot