Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unsupported keys #459

Merged
merged 1 commit into from
Mar 2, 2017
Merged

unsupported keys #459

merged 1 commit into from
Mar 2, 2017

Conversation

procrypt
Copy link
Contributor

@procrypt procrypt commented Mar 1, 2017

@cdrage added sysctls to unsupported keys since we didn't find anything akin in Kubernetes.
Added links to unsupported keys since containers in the same pod can find and communicate with each other using localhost:containerPort

Fixes: #441 #439

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 1, 2017
@kadel
Copy link
Member

kadel commented Mar 1, 2017

I don't think that we should display warning for links.
Only think link does is create env variables, same variables are create by Kubernetes for every service.

We can safely and silently ignore it.

@cdrage
Copy link
Member

cdrage commented Mar 1, 2017

Agreed with @kadel and thanks for adding sysctls to ignore list :)

@kadel kadel merged commit fe632d9 into kubernetes:master Mar 2, 2017
@surajssd surajssd mentioned this pull request Mar 8, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kadel kadel kadel approved these changes

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@procrypt @kadel @cdrage @k8s-ci-robot