Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor how we update controllers #42

Merged
merged 1 commit into from
Jul 16, 2016

Conversation

janetkuo
Copy link
Member

Refactor so that we don't need to copy & paste code for updating each controller.

@sebgoa
Copy link
Contributor

sebgoa commented Jul 16, 2016

Not sure what happened, it seems I added a label while I was sleeping, weird.

@janetkuo is it ready for review+merge or are you still working on it ?

@ngtuna
Copy link
Contributor

ngtuna commented Jul 16, 2016

Thanks @janetkuo . Nice to see a generic update function for controllers. Shall we keep discussing to optimize convert function in order to look better ? It's simply too long.

@janetkuo
Copy link
Member Author

Yes it's ready for review. Agree with Tuna, I'd love to optimize convert as
well.
On Sat, Jul 16, 2016 at 10:27 AM Tuna notifications@github.com wrote:

Thanks @janetkuo https://github.com/janetkuo . Nice to see a generic
update function for controllers. Shall we keep discussing to optimize
convert function in order to look better ? It's simply too long.


You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
#42 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AEpqQx66tM1mFtCGEvljhRUlovCGzBPQks5qWRR8gaJpZM4JN33Z
.

@ngtuna
Copy link
Contributor

ngtuna commented Jul 16, 2016

@janetkuo @Runseb I checked out the PR. It looks good to me.

@ngtuna ngtuna merged commit dc6c232 into kubernetes:master Jul 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants