Removes the TCP output on the Kubernetes / OpenShift artifacts #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
Tests are gunna fail. Ignore tests for now (I'll need to fix them as they test if TCP is included in the conversion). Will work on this. |
cdrage
force-pushed
the
remove-tcp-from-conversion
branch
4 times, most recently
from
bd8c8aa to
1e504ef
Compare
|
Tests pass now! 👍 Had to go through each and every JSON file to update it to not include TCP... Ready for review! |
cdrage
force-pushed
the
remove-tcp-from-conversion
branch
2 times, most recently
from
6c6f4cc to
cb6c9e9
Compare
If TCP is passed in as the protocol, by default, we add TCP as the protocol within the Kubernetes or OpenShift artifacts. By default, TCP is already selected within Kubernetes and thus having the TCP output is redundant. This commit checks to see if TCP has already been selected, and if it has, ignores adding it to the list of ports. Closes kubernetes#392
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If TCP is passed in as the protocol, by default, we add TCP as the
protocol within the Kubernetes or OpenShift artifacts.
By default, TCP is already selected within Kubernetes and thus having
the TCP output is redundant.
This commit checks to see if TCP has already been selected, and if it
has, ignores adding it to the list of ports.
Closes #392