Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant file creation message, and always overwirte files when converting #19

Merged
merged 1 commit into from
Jul 7, 2016
Merged

Remove redundant file creation message, and always overwirte files when converting #19

merged 1 commit into from
Jul 7, 2016

Conversation

janetkuo
Copy link
Member

@janetkuo janetkuo commented Jul 6, 2016

Fixes #18

cc @Runseb @ngtuna

janetkuo
janetkuo reviewed Jul 6, 2016
View reviewed changes
cli/app/app.go
"LogOpt": "",
"ExtraHosts": "",
"LogOpt": "",
"ExtraHosts": "",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes above this line are just gofmt

@ngtuna ngtuna merged commit 134ba7a into kubernetes:master Jul 7, 2016
ngtuna added a commit that referenced this pull request Jul 7, 2016
@ngtuna
Merge pull request #19 from janetkuo
30fa304
ngtuna added a commit that referenced this pull request Jul 7, 2016
@ngtuna
Merge PR #19 'janetkuo-overwrite-not-append-file'
bdf7acd
@ngtuna
Copy link
Contributor

ngtuna commented Jul 7, 2016

I found out somehow os.Create() causes this below issue:

$ kompose convert -o abc.txt -f docker-gitlab.yml
FATA[0000] Failed to write svc to file: write abc.txt: bad file descriptor

@janetkuo
Copy link
Member Author

janetkuo commented Jul 7, 2016

@ngtuna no, it's because the file is closed early, see the fix #24

@ngtuna
Copy link
Contributor

ngtuna commented Jul 7, 2016

Ah my bad. Thanks @janetkuo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janetkuo @ngtuna