feature: change example to use non-root #1879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/feature
k8s-ci-robot
added
approved
cdrage
force-pushed
the
non-root
branch
2 times, most recently
from
61eeeb2 to
03c9670
Compare
TessaIO
reviewed
May 29, 2024
|
|
||
| web: | ||
| container_name: web | ||
| image: quay.io/kompose/web | ||
| ports: | ||
| - "8080:8080" | ||
| - "8080:8080" |
#### What type of PR is this? <!-- Add one of the following kinds: /kind bug /kind cleanup /kind documentation --> /kind feature #### What this PR does / why we need it: This changes our example to use non-root so it runs well on non-root clusters (ex. openshift). We also add debugging tools so we can safely explore the container. /tmp is also added as the directory for the replica or else it fails. #### Which issue(s) this PR fixes: <!-- *Automatically closes linked issue when PR is merged. Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`. --> N/A #### Special notes for your reviewer: Signed-off-by: Charlie Drage <charlie@charliedrage.com>
TessaIO
approved these changes
May 29, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cdrage, TessaIO The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feature: change example to use non-root
What type of PR is this?
/kind feature
What this PR does / why we need it:
This changes our example to use non-root so it runs well on non-root
clusters (ex. openshift).
We also add debugging tools so we can safely explore the container.
/tmp is also added as the directory for the replica or else it fails.
Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
Signed-off-by: Charlie Drage charlie@charliedrage.com