Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds a label for initContainers, test and user-guide #1840

Merged
merged 7 commits into from
Apr 8, 2024

Conversation

sosan
Copy link
Contributor

@sosan sosan commented Mar 13, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

Add label for initContainers
for example:
kompose.init-contaners.name: "init-service"
kompose.init-contaners.image: "busybox:1.28"
kompose.init-contaners.command: "['sh', '-c', 'until nslookup myservice.$(cat /var/run/secrets/kubernetes.io/serviceaccount/namespace).svc.cluster.local; do echo waiting for myservice; sleep 2; done']"

Which issue(s) this PR fixes:

Feature #1772

Special notes for your reviewer:

Signed-off-by: jose luis <2064537+sosan@users.noreply.github.com>
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 13, 2024
@k8s-ci-robot k8s-ci-robot requested review from cdrage and kadel March 13, 2024 19:46
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 13, 2024
Copy link
Member

@TessaIO TessaIO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sosan Thanks for the PR. I put some comments below, and I'll do another round of review once my comments are addressed. One thing to add, can you add some e2e tests for this?

docs/user-guide.md Outdated Show resolved Hide resolved
docs/user-guide.md Outdated Show resolved Hide resolved
docs/user-guide.md Outdated Show resolved Hide resolved
docs/user-guide.md Outdated Show resolved Hide resolved
pkg/transformer/kubernetes/k8sutils.go Outdated Show resolved Hide resolved
pkg/transformer/kubernetes/k8sutils.go Outdated Show resolved Hide resolved
sosan added 2 commits March 18, 2024 00:07
Signed-off-by: jose luis <2064537+sosan@users.noreply.github.com>
Signed-off-by: jose luis <2064537+sosan@users.noreply.github.com>
@sosan
Copy link
Contributor Author

sosan commented Mar 17, 2024

@sosan Thanks for the PR. I put some comments below, and I'll do another round of review once my comments are addressed. One thing to add, can you add some e2e tests for this?

suggestions fixed
added test e2e for initcontainer

===> Starting test <===
convert::expect_success_and_warning: Running: 'kompose -f /home/runner/work/kompose/kompose/script/test/fixtures/initcontainer/compose.yaml convert --stdout --with-kompose-annotation=false' expected_output: '/home/runner/work/kompose/kompose/script/test/fixtures/initcontainer/output-k8s.yaml' expected_warning: ''
PASS: converted output matches
PASS: warning found: ''

Copy link
Member

@cdrage cdrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay!

Some feedback:

  • contaners is spelt wrong
  • To match all the other labels, it should be kompose.init.container.name and kompose.init.container.image and kompose.init.container.command.

Good addition! Again, apologizes for the delay.

pkg/loader/compose/utils.go Outdated Show resolved Hide resolved
sosan and others added 4 commits March 23, 2024 17:24
Signed-off-by: jose luis <2064537+sosan@users.noreply.github.com>
…ernetes#1836)

Bumps [golang.org/x/tools](https://github.com/golang/tools) from 0.16.1 to 0.19.0.
- [Release notes](https://github.com/golang/tools/releases)
- [Commits](golang/tools@v0.16.1...v0.19.0)

---
updated-dependencies:
- dependency-name: golang.org/x/tools
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Adds ability to specify the stage/target of a multistage dockerfile
changed labels to kompose.init.container.name, kompose.init.container.image, kompose.init.container.command
fixed documentation, tests and e2e
also merged main with new commits to this branch

Signed-off-by: jose luis <2064537+sosan@users.noreply.github.com>
@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Mar 23, 2024
@k8s-ci-robot
Copy link
Contributor

Keywords which can automatically close issues and at(@) or hashtag(#) mentions are not allowed in commit messages.

The list of commits with invalid commit messages:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sosan
Copy link
Contributor Author

sosan commented Mar 23, 2024

Sorry for the delay!

Some feedback:

  • contaners is spelt wrong
  • To match all the other labels, it should be kompose.init.container.name and kompose.init.container.image and kompose.init.container.command.

Good addition! Again, apologizes for the delay.

changed labels to kompose.init.container.name, kompose.init.container.image, kompose.init.container.command
fixed documentation, tests and e2e
also merged main with new commits to this branch

@cdrage
Copy link
Member

cdrage commented Apr 2, 2024

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cdrage, sosan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 2, 2024
@cdrage cdrage dismissed TessaIO’s stale review April 2, 2024 12:08

e2e tests have been added now

@cdrage cdrage merged commit c9c1080 into kubernetes:main Apr 8, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants