-
Notifications
You must be signed in to change notification settings - Fork 769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds a label for initContainers, test and user-guide #1840
Conversation
Signed-off-by: jose luis <2064537+sosan@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sosan Thanks for the PR. I put some comments below, and I'll do another round of review once my comments are addressed. One thing to add, can you add some e2e tests for this?
Signed-off-by: jose luis <2064537+sosan@users.noreply.github.com>
suggestions fixed
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay!
Some feedback:
- contaners is spelt wrong
- To match all the other labels, it should be
kompose.init.container.name
andkompose.init.container.image
andkompose.init.container.command
.
Good addition! Again, apologizes for the delay.
Signed-off-by: jose luis <2064537+sosan@users.noreply.github.com>
…ernetes#1836) Bumps [golang.org/x/tools](https://github.com/golang/tools) from 0.16.1 to 0.19.0. - [Release notes](https://github.com/golang/tools/releases) - [Commits](golang/tools@v0.16.1...v0.19.0) --- updated-dependencies: - dependency-name: golang.org/x/tools dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Adds ability to specify the stage/target of a multistage dockerfile
changed labels to kompose.init.container.name, kompose.init.container.image, kompose.init.container.command fixed documentation, tests and e2e also merged main with new commits to this branch Signed-off-by: jose luis <2064537+sosan@users.noreply.github.com>
Keywords which can automatically close issues and at(@) or hashtag(#) mentions are not allowed in commit messages. The list of commits with invalid commit messages:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
changed labels to kompose.init.container.name, kompose.init.container.image, kompose.init.container.command |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cdrage, sosan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Add label for initContainers
for example:
kompose.init-contaners.name: "init-service"
kompose.init-contaners.image: "busybox:1.28"
kompose.init-contaners.command: "['sh', '-c', 'until nslookup myservice.$(cat /var/run/secrets/kubernetes.io/serviceaccount/namespace).svc.cluster.local; do echo waiting for myservice; sleep 2; done']"
Which issue(s) this PR fixes:
Feature #1772
Special notes for your reviewer: